From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: ext Roman Tereshonkov <roman.tereshonkov@nokia.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] Fix IO address issue.
Date: Fri, 10 Oct 2008 14:41:14 +0300 [thread overview]
Message-ID: <20081010114111.GV3044@atomide.com> (raw)
In-Reply-To: <20081010090900.GB29131@gandalf.research.nokia.com>
* Felipe Balbi <felipe.balbi@nokia.com> [081010 12:24]:
> On Fri, Oct 10, 2008 at 12:05:09PM +0300, Tereshonkov Roman wrote:
>
> A patch description would be great here
>
> >
> > Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
>
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
Pushing.
Tony
>
> > ---
> > drivers/misc/sti/sdti.c | 12 ++++++------
> > 1 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/misc/sti/sdti.c b/drivers/misc/sti/sdti.c
> > index c35821d..2631ccf 100644
> > --- a/drivers/misc/sti/sdti.c
> > +++ b/drivers/misc/sti/sdti.c
> > @@ -32,7 +32,7 @@
> > #define CPU2_TRACE_EN 0x02
> >
> > static struct clk *sdti_ck;
> > -unsigned long sti_base, sti_channel_base;
> > +void __iomem *sti_base, *sti_channel_base;
> > static DEFINE_SPINLOCK(sdti_lock);
> >
> > void omap_sti_channel_write_trace(int len, int id, void *data,
> > @@ -137,14 +137,14 @@ static int __devinit omap_sdti_probe(struct platform_device *pdev)
> > }
> >
> > size = res->end - res->start;
> > - sti_base = (unsigned long)ioremap(res->start, size);
> > + sti_base = ioremap(res->start, size);
> > if (unlikely(!sti_base))
> > return -ENODEV;
> >
> > size = cres->end - cres->start;
> > - sti_channel_base = (unsigned long)ioremap(cres->start, size);
> > + sti_channel_base = ioremap(cres->start, size);
> > if (unlikely(!sti_channel_base)) {
> > - iounmap((void *)sti_base);
> > + iounmap(sti_base);
> > return -ENODEV;
> > }
> >
> > @@ -153,8 +153,8 @@ static int __devinit omap_sdti_probe(struct platform_device *pdev)
> >
> > static int __devexit omap_sdti_remove(struct platform_device *pdev)
> > {
> > - iounmap((void *)sti_channel_base);
> > - iounmap((void *)sti_base);
> > + iounmap(sti_channel_base);
> > + iounmap(sti_base);
> > omap_sdti_exit();
> >
> > return 0;
> > --
> > 1.5.5.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> balbi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-10 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 9:05 [PATCH] Fix IO address issue Roman Tereshonkov
2008-10-10 9:09 ` Felipe Balbi
2008-10-10 11:41 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-09 12:27 Roman Tereshonkov
2008-10-09 12:40 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010114111.GV3044@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=roman.tereshonkov@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.