All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, michael@free-electrons.com
Subject: Re: [Qemu-devel] [patch 2/2] Add Flash support to the Versatile PB platform
Date: Fri, 10 Oct 2008 15:17:16 +0200	[thread overview]
Message-ID: <20081010151716.1407f4ba@surf> (raw)
In-Reply-To: <200810101402.18569.paul@codesourcery.com>

Le Fri, 10 Oct 2008 14:02:17 +0100,
Paul Brook <paul@codesourcery.com> a écrit :

> > +    if (! hasflash) {
> > +      versatile_binfo.ram_size = ram_size;
> 
> This should be dependent on the presence of the -kernel option, not
> the absence of flash.

Yes, makes sense. How should it behave when neither -kernel nor -pflash
are present ? Just display an error message and exit ?

Thanks a lot for your feedback,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2008-10-10 13:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-10  8:36 [Qemu-devel] [patch 0/2] Add flash emulation to the ARM Versatile PB platform Thomas Petazzoni
2008-10-10  8:36 ` [Qemu-devel] [patch 1/2] Increase write buffer size in pflash emulation Thomas Petazzoni
2008-10-10  8:36 ` [Qemu-devel] [patch 2/2] Add Flash support to the Versatile PB platform Thomas Petazzoni
2008-10-10 13:02   ` Paul Brook
2008-10-10 13:17     ` Thomas Petazzoni [this message]
2008-10-10 13:32       ` Paul Brook
2008-10-10 14:37         ` Thomas Petazzoni
2008-10-10  9:01 ` [Qemu-devel] [patch 0/2] Add flash emulation to the ARM " Aurelien Jarno
2008-10-10  9:48   ` Thomas Petazzoni
2008-10-10 14:02     ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-10 14:52       ` Thomas Petazzoni
2008-10-10 21:20         ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-10 14:45 ` [Qemu-devel] [PATCH] Update documentation Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081010151716.1407f4ba@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=michael@free-electrons.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.