From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip Date: Fri, 10 Oct 2008 17:42:56 +0530 Message-ID: <200810101742.56814.amit.shah@redhat.com> References: <200810031306.53295.amit.shah@redhat.com> <20081003103754.GA29951@yukikaze> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "Yang, Sheng" , "'kvm@vger.kernel.org'" , sheng@linux.intel.com To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34153 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754389AbYJJMOV (ORCPT ); Fri, 10 Oct 2008 08:14:21 -0400 In-Reply-To: <20081003103754.GA29951@yukikaze> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: * On Friday 03 Oct 2008 16:07:54 Sheng Yang wrote: > @@ -319,15 +319,23 @@ static int kvm_vm_ioctl_assign_device(struct kvm > *kvm, > > list_add(&match->list, &kvm->arch.assigned_dev_head); > > + r = kvm_request_irq_source_id(kvm); This should be done in the kvm_vm_ioctl_assign_irq call, just after registering the ack notifier. Amit.