From: Matthew Wilcox <matthew@wil.cx>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] sd: remove command-size switching code
Date: Fri, 10 Oct 2008 14:10:38 -0600 [thread overview]
Message-ID: <20081010201037.GK25780@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0810101559440.14173-100000@iolanthe.rowland.org>
On Fri, Oct 10, 2008 at 04:03:20PM -0400, Alan Stern wrote:
> This patch (as1138) removes from sd.c some old code for switching from
> 10-byte commands to 6-byte commands. This code is redundant -- the
> switching for READ and WRITE is already handled in
> scsi_io_completion() and the switching for MODE SENSE is already
> handled in scsi_mode_sense(). (There is no comparable switch for MODE
> SELECT, but I doubt one is needed.)
I noticed this odd duplication a few months ago and meant to ask about
it then, but forgot. Thanks for cleaning this up.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-10-10 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 20:03 [PATCH] sd: remove command-size switching code Alan Stern
2008-10-10 20:10 ` Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-25 19:03 Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010201037.GK25780@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.