From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Huang Ying <ying.huang@intel.com>,
linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de
Subject: Re: [PATCH -mm -v5] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h
Date: Fri, 10 Oct 2008 23:49:58 +0200 [thread overview]
Message-ID: <20081010214958.GA7708@elte.hu> (raw)
In-Reply-To: <20081010144335.65d8153b.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 08 Oct 2008 17:44:30 +0800
> Huang Ying <ying.huang@intel.com> wrote:
>
> > From: Huang Ying <ying.huang@intel.com>
> >
> > asm/atomic.h contains both declaration and implementation of atomic_t. So
> > there are some implementation related files included in asm/atomic.h. And
> > atomic_t is a typedef. Combination of above makes it impossible to use
> > atomic_t in files included by atomic.h. Such as atomic_t can not be used
> > in linux/kernel.h on i386, because it is included by asm/atomic.h.
> >
> > It is reasonable to separate declaration from implementation. So a new
> > file atomic_types.h is added for every architecture to accommodate the
> > declaration of atomic_t.
> >
> > Includes fixes from Andrew Moton.
> >
> > Signed-off-by: Huang Ying <ying.huang@intel.com>
> > Reviewed-by: Ingo Molnar <mingo@elte.hu>
>
> The difference between what-i-currently-have and what-you-just-sent is
> below. It's quite large.
>
> Can you explain this update please?
i've been giving review feedback to make it all fit into existing
namespace concepts better. Should have no change in functionality. (But
i have not tested it)
Ingo
next prev parent reply other threads:[~2008-10-10 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 9:44 [PATCH -mm -v5] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h Huang Ying
2008-10-10 21:43 ` Andrew Morton
2008-10-10 21:49 ` Ingo Molnar [this message]
2008-10-10 22:54 ` Andrew Morton
2008-10-14 18:47 ` Matthew Wilcox
2008-10-15 22:11 ` Andrew Morton
2008-10-15 22:19 ` Matthew Wilcox
2008-10-15 22:31 ` Andrew Morton
2008-10-18 4:00 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010214958.GA7708@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.