From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-mips@linux-mips.org, "Paoletti,
Tomaso" <Tomaso.Paoletti@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h.
Date: Sat, 11 Oct 2008 15:57:28 +0100 [thread overview]
Message-ID: <20081011145728.GA6570@linux-mips.org> (raw)
In-Reply-To: <48EFAF9E.9010806@caviumnetworks.com>
On Fri, Oct 10, 2008 at 12:40:14PM -0700, David Daney wrote:
> Add missing include in arch/mips/include/asm/ptrace.h.
>
> Recent reorganization seems to have lost this include. You cannot
> build without it.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> Signed-off-by: Tomaso Paoletti <tpaoletti@caviumnetworks.com>
> ---
> arch/mips/include/asm/ptrace.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7fe9812..36872b8 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -120,6 +120,8 @@ struct pt_watch_regs {
>
> #include <linux/compiler.h>
> #include <linux/linkage.h>
> +#include <linux/sched.h>
Sched.h is one of those include files that drag in way to many other
header files. So I went for a forward declaration of struct task_struct
instead.
Thanks,
Ralf
prev parent reply other threads:[~2008-10-11 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 19:40 [PATCH] MIPS: Add missing include in arch/mips/include/asm/ptrace.h David Daney
2008-10-11 7:41 ` Geert Uytterhoeven
2008-10-11 14:57 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081011145728.GA6570@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Tomaso.Paoletti@caviumnetworks.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.