From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KozNb-0007yq-B2
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 07:44:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KozNa-0007yV-Lq
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 07:44:58 -0400
Received: from [199.232.76.173] (port=53081 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KozNa-0007yN-DW
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 07:44:58 -0400
Received: from hall.aurel32.net ([88.191.82.174]:56999)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1KozNa-0006xk-2z
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 07:44:58 -0400
Received: from volta-wlan.aurel32.net ([2002:52e8:2fb:ffff:21d:e0ff:fe49:1047]
	helo=volta.aurel32.net)
	by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <aurelien@aurel32.net>)
	id 1KozNS-0005pY-Tm
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 13:44:51 +0200
Received: from aurel32 by volta.aurel32.net with local (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1KozNM-0005m9-In
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 13:44:44 +0200
Date: Sun, 12 Oct 2008 13:44:44 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] Re: [5465] hw/apic.c: use __builtin funtions
	instead of assembly code
Message-ID: <20081012114444.GG9537@volta.aurel32.net>
References: <E1KopCv-0001X3-Qp@cvs.savannah.gnu.org> <48F1CFBB.2000509@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <48F1CFBB.2000509@web.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Oct 12, 2008 at 12:21:47PM +0200, Jan Kiszka wrote:
> Aurelien Jarno wrote:
> > Revision: 5465
> >           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5465
> > Author:   aurel32
> > Date:     2008-10-12 00:53:17 +0000 (Sun, 12 Oct 2008)
> > 
> > Log Message:
> > -----------
> > hw/apic.c: use __builtin funtions instead of assembly code
> > 
> > Suggested by malc.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > 
> > Modified Paths:
> > --------------
> >     trunk/hw/apic.c
> > 
> > Modified: trunk/hw/apic.c
> > ===================================================================
> > --- trunk/hw/apic.c	2008-10-12 00:53:08 UTC (rev 5464)
> > +++ trunk/hw/apic.c	2008-10-12 00:53:17 UTC (rev 5465)
> > @@ -104,15 +104,14 @@
> >  static void apic_set_irq(APICState *s, int vector_num, int trigger_mode);
> >  static void apic_update_irq(APICState *s);
> >  
> > -/* Find first bit starting from msb. Return 0 if value = 0 */
> > +/* Find first bit starting from msb */
> >  static int fls_bit(uint32_t value)
> >  {
> > +#if defined(__GNUC__)
> > +    return 31 - __builtin_clz(value);
> 
> That as well as most (if not all) of the __builtin_* changes are gcc3.4+
> stuff. Thus gcc3.3 builds are unfortunately broken now.
> 

That should be fixed now.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net