From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Steven Noonan" <steven@uplinklabs.net>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Steve French" <sfrench@us.ibm.com>,
"Jeff Layton" <jlayton@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: fix build on !CONFIG_KEYS
Date: Sun, 12 Oct 2008 13:30:48 +0200 [thread overview]
Message-ID: <200810121330.49028.rjw@sisk.pl> (raw)
In-Reply-To: <f488382f0810120415k5fa80a0x328a4b0c450b1fd5@mail.gmail.com>
On Sunday, 12 of October 2008, Steven Noonan wrote:
> Hmm, which fix is correct though? Depending on KEYS in Kconfig, or
> adding a nop for it?
Well, according to git-blame the key_revoke() has been added to fs/cifs/sess.c
only recently while key_put() was there before. For this reason I think it's
correct to handle key_revoke() in analogy with key_put(), ie. add an empty
definition for it if CONFIG_KEYS is unset.
Thanks,
Rafael
> On Sun, Oct 12, 2008 at 4:14 AM, Steven Noonan <steven@uplinklabs.net> wrote:
> > Dang it. I got to this one late. I literally -just- fixed it locally.
> >
> > - Steven
> >
> > On Sun, Oct 12, 2008 at 4:17 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >> On Sunday, 12 of October 2008, Ingo Molnar wrote:
> >>>
> >>> hi,
> >>>
> >>> find a quick build fix for CIFS below - you might have it already.
> >>> Please double-check.
> >>
> >> Heh, I've just sent another fix for the same issue. :-)
> >>
> >> Thanks,
> >> Rafael
> >>
> >>
> >>> ----------->
> >>> From 9d65371d47bc0285a557f279d402764f73551d3c Mon Sep 17 00:00:00 2001
> >>> From: Ingo Molnar <mingo@elte.hu>
> >>> Date: Sun, 12 Oct 2008 13:01:52 +0200
> >>> Subject: [PATCH] cifs: fix build on !CONFIG_KEYS
> >>> MIME-Version: 1.0
> >>> Content-Type: text/plain; charset=utf-8
> >>> Content-Transfer-Encoding: 8bit
> >>>
> >>> CIFS has keys infrastructure dependencies:
> >>>
> >>> fs/cifs/sess.c: In function 'CIFS_SessSetup':
> >>> fs/cifs/sess.c:628: error: implicit declaration of function 'key_revoke'
> >>>
> >>> So express that dependency in the Kconfig.
> >>>
> >>> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> >>> ---
> >>> fs/Kconfig | 1 +
> >>> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/fs/Kconfig b/fs/Kconfig
> >>> index 40183d9..c0eade5 100644
> >>> --- a/fs/Kconfig
> >>> +++ b/fs/Kconfig
> >>> @@ -1876,6 +1876,7 @@ config SMB_NLS_REMOTE
> >>> config CIFS
> >>> tristate "CIFS support (advanced network filesystem, SMBFS successor)"
> >>> depends on INET
> >>> + depends on KEYS
> >>> select NLS
> >>> help
> >>> This is the client VFS module for the Common Internet File System
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >> Please read the FAQ at http://www.tux.org/lkml/
> >>
> >
>
>
next prev parent reply other threads:[~2008-10-12 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 11:09 [PATCH] cifs: fix build on !CONFIG_KEYS Ingo Molnar
2008-10-12 11:17 ` Rafael J. Wysocki
2008-10-12 11:14 ` Steven Noonan
2008-10-12 11:15 ` Steven Noonan
2008-10-12 11:30 ` Rafael J. Wysocki [this message]
2008-10-12 11:30 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810121330.49028.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfrench@us.ibm.com \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.