From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5466] Only use __builtin_* with GCC >= 3.4
Date: Sun, 12 Oct 2008 15:23:48 +0100 [thread overview]
Message-ID: <20081012142348.GA18814@shareable.org> (raw)
In-Reply-To: <48F1EE9B.6040706@redhat.com>
Avi Kivity wrote:
> >-#if defined(__GNUC__)
> >+#if defined(__GNUC__) && ((__GNUC__ > 3) || (__GNUC__ == 3 &&
> >__GNUC_MINOR__ >= 4))
>
> Couldn't this be wrapped in GCC_BUILTINS_AVAILABLE or GCC_ATLEAST_3_4?
> My eyes hurt.
Glibc uses "#if __GNUC_PREREQ (3,4)" which is quite neat.
Do "grep -R GNUC_PREREQ /usr/include".
I use (and define if not already defined) the same macro in my
programs, on the assumption that the macro's meaning is unlikely to
ever change or be different elsewhere.
-- Jamie
next prev parent reply other threads:[~2008-10-12 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 11:44 [Qemu-devel] [5466] Only use __builtin_* with GCC >= 3.4 Aurelien Jarno
2008-10-12 12:33 ` Avi Kivity
2008-10-12 14:23 ` Jamie Lokier [this message]
2008-10-12 15:02 ` Avi Kivity
2008-10-12 15:33 ` Jamie Lokier
2008-10-12 19:10 ` M. Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081012142348.GA18814@shareable.org \
--to=jamie@shareable.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.