From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [SH4] Fix swap.b
Date: Mon, 13 Oct 2008 01:31:59 +0200 [thread overview]
Message-ID: <20081012233159.GC1463@volta.aurel32.net> (raw)
In-Reply-To: <200810121921.05267.vladimir@codesourcery.com>
On Sun, Oct 12, 2008 at 07:21:05PM +0400, Vladimir Prus wrote:
>
> The SH4 manual documents the swap.b instruction as follows:
>
> SWAP.B Rm,Rn
> Rm → swap lower 2 bytes → Rn
>
> Current QEMU code, in addition to the above, also clears the high
> 16 bits. The immediate breakage I saw is that htonl function applied
> to netmask of 255.255.255.0 gives 0, which breaks all networking.
> Attached patch fixes the problem.
>
Thanks, applied.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2008-10-12 23:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 15:21 [Qemu-devel] [SH4] Fix swap.b Vladimir Prus
2008-10-12 23:31 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081012233159.GC1463@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.