From: Stephen Hemminger <shemminger@vyatta.com>
To: Arkadiusz Miskiewicz <arekm@maven.pl>
Cc: Patrick McHardy <kaber@trash.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [IPROUTE]: Fix up "ip link" help text
Date: Mon, 13 Oct 2008 11:07:46 -0700 [thread overview]
Message-ID: <20081013110746.563d1226@extreme> (raw)
In-Reply-To: <200810131917.00864.arekm@maven.pl>
On Mon, 13 Oct 2008 19:17:00 +0200
Arkadiusz Miskiewicz <arekm@maven.pl> wrote:
> On Monday 13 of October 2008, Stephen Hemminger wrote:
> > On Tue, 07 Oct 2008 23:02:17 +0200
> >
> > Patrick McHardy <kaber@trash.net> wrote:
> > > Arkadiusz Miskiewicz wrote:
> > > > Runtime dependand help doesn't look sane. Help should always show all
> > > > possible options/command while trying to use unsupported option should
> > > > display error message.
> > >
> > > That makes sense. But don't complain to me about the quality
> > > of the error messages afterwards please :)
> >
> > I applied a variant of Patrick's original patch. I added text for delete,
> > and avoided some code movement. The help text should only show what is
> > supported otherwise there will be user complaints.
>
> Too bad.
>
> Help should show all options while trying to use unsupported ones should
> yeld "unsupported"/some error message.
>
> Will ipv6 options etc, etc also be hidden when ipv6 not available?
>
The options won't show on older kernels. It is not a kernel config option
difference, it is old legacy code, like back to 2.4 where the API's just
aren't there.
prev parent reply other threads:[~2008-10-13 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 15:17 [IPROUTE]: Fix up "ip link" help text Patrick McHardy
[not found] ` <200810072206.03062.arekm@maven.pl>
2008-10-07 21:02 ` Patrick McHardy
2008-10-07 21:18 ` Stephen Hemminger
2008-10-13 14:21 ` Stephen Hemminger
2008-10-13 16:36 ` Ben Greear
[not found] ` <200810131917.00864.arekm@maven.pl>
2008-10-13 18:07 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013110746.563d1226@extreme \
--to=shemminger@vyatta.com \
--cc=arekm@maven.pl \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.