From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 1/2] KVM: Handle multiple interrupt sources Date: Mon, 13 Oct 2008 13:10:55 +0800 Message-ID: <200810131310.56577.sheng@linux.intel.com> References: <81778567.14531223874378653.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: avi@redhat.com, kvm@vger.kernel.org, xiantao zhang To: Amit Shah Return-path: Received: from mga05.intel.com ([192.55.52.89]:27841 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751778AbYJMFO5 (ORCPT ); Mon, 13 Oct 2008 01:14:57 -0400 In-Reply-To: <81778567.14531223874378653.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Monday 13 October 2008 13:06:18 Amit Shah wrote: > ----- "Sheng Yang" wrote: > > On Saturday 11 October 2008 16:10:51 Amit Shah wrote: > > > From: Sheng Yang > > > > > > Keep a record of current interrupt state before injecting. Don't > > > assert/deassert repeatedly, so that every caller of kvm_set_irq() > > > can be identified as a separate interrupt source for the IOAPIC/PIC > > > to implement logical OR of level triggered interrupts on one IRQ > > > > line. > > > > > Notice that userspace devices are treated as one device for each > > > > IRQ > > > > > line. The correctness of sharing interrupt for each IRQ line should > > > > be > > > > > ensured by the userspace program (QEmu). > > > > > > [Amit: rebase to kvm.git HEAD] > > > > Hi, Amit > > > > Thanks for your work! > > > > But maybe I miss something. I suppose my later patch can work > > indepently? I > > think the second patch should solve the whole problem (sorry to reply > > it to > > the second rather than [0/2] which made confusion...). Can you have a > > check? > > I'm not sure I understand. Which concern are you talking about? > > I used the latest patch that you sent and I also verified that it works. > Well, at least I meant to replace all of my first two patches with my later one... I suppose the second patch(my later one, derived from Avi's suggestion) should work alone without the first one... -- regards Yang, Sheng