From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pierre Habouzit <madcoder@debian.org>,
git@vger.kernel.org, Erez Zilber <erezzi.list@gmail.com>
Subject: Re: [RFC PATCH] describe: Make --tags and --all match lightweight tags more often
Date: Mon, 13 Oct 2008 07:32:02 -0700 [thread overview]
Message-ID: <20081013143202.GO4856@spearce.org> (raw)
In-Reply-To: <7vwsggl3ep.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
>
> The primary mode of operation without --tags of "describe" is about coming
> up with version numbers, and as such, it should try to base its output on
> immutable anchors as much as possible. For that reason, I think it should
> use "tag " line from the tag object, not the name of the ref, to describe
> the committish. They should match (otherwise fsck would say something
> about it) in practice, though...
FWIW the use of "tag " line for an annotated tag being output is what
212945d4 (Teach git-describe to verify annotated tag names before
output) was all about. That has been in tree since v1.5.5-rc0~86^2.
So we already are doing (have been doing) exactly what you are
asking for.
Or did I misunderstand you?
--
Shawn.
next prev parent reply other threads:[~2008-10-13 14:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 13:48 git-describe doesn't show the most recent tag Erez Zilber
2008-09-28 13:55 ` Pierre Habouzit
2008-09-28 14:29 ` Erez Zilber
2008-09-28 14:39 ` Pierre Habouzit
2008-09-28 15:03 ` Pierre Habouzit
2008-09-28 15:12 ` [PATCH] doc: enhance git describe --tags help Pierre Habouzit
2008-09-29 15:01 ` Shawn O. Pearce
2008-09-30 8:39 ` Pierre Habouzit
2008-10-10 16:59 ` [RFC PATCH] describe: Make --tags and --all match lightweight tags more often Shawn O. Pearce
2008-10-10 17:12 ` Pierre Habouzit
2008-10-10 18:18 ` Junio C Hamano
2008-10-13 14:32 ` Shawn O. Pearce [this message]
2008-10-13 14:39 ` [PATCH v2] " Shawn O. Pearce
2008-10-15 12:54 ` Santi Béjar
2008-10-11 22:47 ` [RFC PATCH] " Andreas Ericsson
2008-10-12 18:00 ` Shawn O. Pearce
2008-10-12 18:13 ` Andreas Ericsson
2008-10-12 18:29 ` Uwe Kleine-König
2008-09-30 9:56 ` [PATCH] doc: enhance git describe --tags help Uwe Kleine-König
2008-09-30 10:09 ` Andreas Ericsson
2008-09-30 19:04 ` Shawn O. Pearce
2008-09-30 22:14 ` Uwe Kleine-König
2008-09-30 22:26 ` Shawn O. Pearce
2008-10-15 20:05 ` Uwe Kleine-König
2008-09-28 15:05 ` git-describe doesn't show the most recent tag Erez Zilber
2008-09-28 14:51 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013143202.GO4856@spearce.org \
--to=spearce@spearce.org \
--cc=erezzi.list@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.