From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from WA4EHSOBE003.bigfish.com (outbound-wa4.frontbridge.com [216.32.181.16]) by ozlabs.org (Postfix) with ESMTP id E26FCDE08B for ; Tue, 14 Oct 2008 02:22:05 +1100 (EST) Date: Mon, 13 Oct 2008 17:21:39 +0200 From: Robert Richter To: Arnd Bergmann Subject: Re: [PATCH] powerpc/cell/oprofile: vma_map: fix test on overlay_tbl_offset Message-ID: <20081013152139.GB23557@erda.amd.com> References: <1223357268.8157.38.camel@pasglop> <200810071038.34085.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <200810071038.34085.arnd@arndb.de> Cc: linuxppc-dev@ozlabs.org, Paul Mackerras , Roel Kluin <12o3l@tiscali.nl>, oprofile-list@lists.sourceforge.net List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07.10.08 10:38:33, Arnd Bergmann wrote: > From: Roel Kluin <12o3l@tiscali.nl> > > Offset is unsigned and when an address isn't found in the vma map > vma_map_lookup() returns the vma physical address + 0x10000000. > > vma_map_lookup used to return 0xffffffff on a failed lookup, but > a change was made to return the vma physical address + 0x10000000 > There are two callers of vam_map_lookup: one of them correctly > deals with this new return value, but the other (below) did not. > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> > Acked-by: Maynard Johnson > Signed-off-by: Arnd Bergmann > Cc: oprofile-list@lists.sf.net > Cc: Carl Love The patch has been applied to the powerpc-for-paul branch of git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git Thanks Roel and Arnd, -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com