From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Neil Brown <neilb@suse.de>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/3] client-side lockd doesn't start UDP listener
Date: Mon, 13 Oct 2008 16:57:12 -0400 [thread overview]
Message-ID: <20081013205712.GF31876@fieldses.org> (raw)
In-Reply-To: <668D398B-7814-4831-ABC2-8F8CF1FBE4D0@oracle.com>
On Mon, Oct 13, 2008 at 04:45:47PM -0400, Chuck Lever wrote:
> NFSD start-up code makes two separate and unconditional calls to
> lockd_up(): one for UDP and one for TCP. So whether or not NFSD
> actually honors the "-T" and "-U" flags, lockd certainly does not honor
> them in current (unpatched) code.
>
> In other words, the patches you've already reviewed shouldn't change the
> server's behavior around -T/-U. Only the client side should be
> affected.
>
> It looks like, prior to commit 24e36663, the client side started both
> lockd listeners no matter what type of mount was requested.
>
> Additional review is welcome, but let's just move forward with what
> you've already got.
OK, sounds fine to me.
The rpc.nfsd man page could still use revision, though.
--b.
next prev parent reply other threads:[~2008-10-13 20:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 21:15 [PATCH 0/3] client-side lockd doesn't start UDP listener Chuck Lever
[not found] ` <20081003211305.9870.6835.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-10-03 21:15 ` [PATCH 1/3] NLM: Always start both UDP and TCP listeners Chuck Lever
2008-10-03 21:15 ` [PATCH 2/3] NLM: Remove "proto" argument from lockd_up() Chuck Lever
2008-10-03 21:15 ` [PATCH 3/3] NLM: Remove unused argument from svc_addsock() function Chuck Lever
2008-10-04 21:36 ` [PATCH 0/3] client-side lockd doesn't start UDP listener J. Bruce Fields
2008-10-12 23:15 ` Neil Brown
[not found] ` <18674.34066.316972.695627-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-10-13 15:42 ` Chuck Lever
2008-10-13 17:46 ` J. Bruce Fields
2008-10-13 20:45 ` Chuck Lever
2008-10-13 20:57 ` J. Bruce Fields [this message]
2008-10-14 9:54 ` Neil Brown
[not found] ` <18676.27741.921124.742371-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-10-14 15:52 ` Chuck Lever
2008-10-14 17:43 ` J. Bruce Fields
2008-10-14 18:14 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013205712.GF31876@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.