From: Ben Dooks <ben-linux@fluff.org>
To: David Miller <davem@davemloft.net>
Cc: cooloney@kernel.org, ben@simtec.co.uk, s.hauer@pengutronix.de,
jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jherrero@hvsistemas.es
Subject: Re: [PATCH 1/1] netdev: DM9000: Added typecasting to supress some warnings on Blackfin
Date: Tue, 14 Oct 2008 00:18:38 +0100 [thread overview]
Message-ID: <20081013231837.GL6646@trinity.fluff.org> (raw)
In-Reply-To: <20081013.030150.96524866.davem@davemloft.net>
On Mon, Oct 13, 2008 at 03:01:50AM -0700, David Miller wrote:
> From: Bryan Wu <cooloney@kernel.org>
> Date: Mon, 13 Oct 2008 17:10:09 +0800
>
> > From: Javier Herrero <jherrero@hvsistemas.es>
> >
> > Signed-off-by: Javier Herrero <jherrero@hvsistemas.es>
> > Signed-off-by: Bryan Wu <cooloney@kernel.org>
>
> This is not only inelegant, it'll likely break things on
> 64-bit MIPS or any other case where the upper 32-bit matter.
>
> I'd rather see Blackfin fix it's I/O accessor prototypes
> to take a proper __iomem pointer.
How much would it hurt to provide blackfin wide
readsb and friends with the correct prototype and
remove the nasty blackfin hack in the dm9000.c driver
for good?
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2008-10-13 23:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 9:10 [PATCH 1/1] netdev: DM9000: Added typecasting to supress some warnings on Blackfin Bryan Wu
2008-10-13 9:17 ` Ben Dooks
2008-10-13 9:28 ` Javier Herrero
2008-10-13 9:52 ` Bryan Wu
2008-10-13 10:24 ` Mike Frysinger
2008-10-13 10:27 ` Bryan Wu
2008-10-13 9:51 ` Bryan Wu
2008-10-13 10:01 ` David Miller
2008-10-13 23:18 ` Ben Dooks [this message]
2008-10-13 12:41 ` Stephen Hemminger
2008-10-14 8:50 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013231837.GL6646@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=ben@simtec.co.uk \
--cc=cooloney@kernel.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jherrero@hvsistemas.es \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.