From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KpjSf-0006hI-G3
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 08:57:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KpjSd-0006h2-5w
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 08:57:16 -0400
Received: from [199.232.76.173] (port=44129 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KpjSc-0006gy-Vu
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 08:57:15 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:36968)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <froydnj@codesourcery.com>) id 1KpjSc-0000Ir-Nc
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 08:57:14 -0400
Date: Tue, 14 Oct 2008 05:57:11 -0700
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] gdbstub: remove unused local variable
Message-ID: <20081014125710.GI18389@codesourcery.com>
References: <48F46265.3000007@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48F46265.3000007@siemens.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Tue, Oct 14, 2008 at 11:12:05AM +0200, Jan Kiszka wrote:
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
>  #else
>      else if (n < 64) {
>          /* f0-f31 */
> -        uint32_t fpr;
> -
>          env->fpr[n] = ldfl_p(mem_buf);
>          return 4;
>      } else if (n < 80) {

And if somebody wanted to fix that to return 8 instead of 4, that'd be
great too. :)

-Nathan