All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Handle environment variables like commands
Date: Wed, 15 Oct 2008 13:01:56 +0200	[thread overview]
Message-ID: <20081015110156.306B581C99CD@gemini.denx.de> (raw)
In-Reply-To: <20081015104550.GB6881@colossus>

Dear Petri Lehtinen,

In message <20081015104550.GB6881@colossus> you wrote:
>
> > The command interpreter checks always if an environment variable
> > for that name exists and in this case the content of the variable
> > is executed. It becomes possible to redefine all U-Boot commands.
> > A new "builtin" command is added to be able to run builtin U-boot commands
> > even if they are redefined.
...
> It seems to me that the "builtin" command itself can still be
> redefined. Is this an issue?

Good catch. Yes, this must be prevented. Any variable named "builtin"
must be ignored here - i. e. we should issue  an  erro  when  someone
tries  a  "setenv", and ignore this variable explicitly (just in case
someone sneaks this into the default environment,  or  uses  un-fixed
Linux tools to create such a variable).

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Objects in mirror are closer than they appear.

  reply	other threads:[~2008-10-15 11:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 10:09 [U-Boot] [PATCH] Handle environment variables like commands Stefano Babic
2008-10-15 10:45 ` Petri Lehtinen
2008-10-15 11:01   ` Wolfgang Denk [this message]
2008-10-15 12:01     ` stefano babic
2008-10-15 12:25       ` Wolfgang Denk
2008-10-15 10:57 ` Wolfgang Denk
2008-10-15 11:56   ` stefano babic
2008-10-15 12:26     ` Wolfgang Denk
2008-10-15 12:09   ` Joakim Tjernlund
  -- strict thread matches above, loose matches on Subject: below --
2008-10-15 13:56 Stefano Babic
2008-10-19 12:05 ` Wolfgang Denk
2008-10-20  7:50   ` stefano babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081015110156.306B581C99CD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.