diff for duplicates of <20081015115153.GA16413@elte.hu> diff --git a/a/1.txt b/N1/1.txt index 1e6a584..f359703 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,3 @@ - * Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > I guess SMP kernel running on UP? In such a case the module .text @@ -20,41 +19,3 @@ today. Thanks! Ingo ------------------> ->From 5870942537422066655816e971629aa729c023d8 Mon Sep 17 00:00:00 2001 -From: Jiri Slaby <jirislaby@gmail.com> -Date: Mon, 13 Oct 2008 17:11:33 +0200 -Subject: [PATCH] x86: fix CONFIG_DEBUG_VIRTUAL=y boot crash on x86-64 - -Alan reported a bootup crash in the module loader: - -> BUG? vmalloc_to_page (from text_poke+0x30/0x14a): ffffffffa01e40b1 - -SMP kernel is running on UP, in such a case the module .text -is patched to use UP locks before the module is added to the modules -list and it thinks there are no valid data at that place while -patching. - -Also the !is_module_address(addr) test is useless now. - -Reported-by: Alan Cox <alan@lxorguk.ukuu.org.uk> -Signed-off-by: Ingo Molnar <mingo@elte.hu> -Tested-by: Alan Cox <alan@lxorguk.ukuu.org.uk> ---- - include/linux/mm.h | 4 ++++ - 1 files changed, 4 insertions(+), 0 deletions(-) - -diff --git a/include/linux/mm.h b/include/linux/mm.h -index c61ba10..45772fd 100644 ---- a/include/linux/mm.h -+++ b/include/linux/mm.h -@@ -267,6 +267,10 @@ static inline int is_vmalloc_addr(const void *x) - #ifdef CONFIG_MMU - unsigned long addr = (unsigned long)x; - -+#ifdef CONFIG_X86_64 -+ if (addr >= MODULES_VADDR && addr < MODULES_END) -+ return 1; -+#endif - return addr >= VMALLOC_START && addr < VMALLOC_END; - #else - return 0; diff --git a/a/content_digest b/N1/content_digest index b9e5cf5..55c72cc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,7 +11,6 @@ " linux-mm@kvack.org\0" "\00:1\0" "b\0" - "\n" "* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:\n" "\n" "> > I guess SMP kernel running on UP? In such a case the module .text\n" @@ -32,44 +31,6 @@ "\n" "\tIngo\n" "\n" - "------------------>\n" - ">From 5870942537422066655816e971629aa729c023d8 Mon Sep 17 00:00:00 2001\n" - "From: Jiri Slaby <jirislaby@gmail.com>\n" - "Date: Mon, 13 Oct 2008 17:11:33 +0200\n" - "Subject: [PATCH] x86: fix CONFIG_DEBUG_VIRTUAL=y boot crash on x86-64\n" - "\n" - "Alan reported a bootup crash in the module loader:\n" - "\n" - "> BUG? vmalloc_to_page (from text_poke+0x30/0x14a): ffffffffa01e40b1\n" - "\n" - "SMP kernel is running on UP, in such a case the module .text\n" - "is patched to use UP locks before the module is added to the modules\n" - "list and it thinks there are no valid data at that place while\n" - "patching.\n" - "\n" - "Also the !is_module_address(addr) test is useless now.\n" - "\n" - "Reported-by: Alan Cox <alan@lxorguk.ukuu.org.uk>\n" - "Signed-off-by: Ingo Molnar <mingo@elte.hu>\n" - "Tested-by: Alan Cox <alan@lxorguk.ukuu.org.uk>\n" - "---\n" - " include/linux/mm.h | 4 ++++\n" - " 1 files changed, 4 insertions(+), 0 deletions(-)\n" - "\n" - "diff --git a/include/linux/mm.h b/include/linux/mm.h\n" - "index c61ba10..45772fd 100644\n" - "--- a/include/linux/mm.h\n" - "+++ b/include/linux/mm.h\n" - "@@ -267,6 +267,10 @@ static inline int is_vmalloc_addr(const void *x)\n" - " #ifdef CONFIG_MMU\n" - " \tunsigned long addr = (unsigned long)x;\n" - " \n" - "+#ifdef CONFIG_X86_64\n" - "+\tif (addr >= MODULES_VADDR && addr < MODULES_END)\n" - "+\t\treturn 1;\n" - "+#endif\n" - " \treturn addr >= VMALLOC_START && addr < VMALLOC_END;\n" - " #else\n" - " \treturn 0;" + ------------------> -8d968e1587e99bdbad44229d5b63d2b6352aa345bb39599751190e10a0828115 +f9e526925fb3fbb1ac929949fa0decf2d1322b91e1c5fbdff830e1ab023c6560
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.