From: Grant Likely <grant.likely@secretlab.ca>
To: Wolfgang Ocker <weo@reccoware.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: SPI: specify chip select active high
Date: Wed, 15 Oct 2008 08:22:28 -0600 [thread overview]
Message-ID: <20081015142228.GD16262@secretlab.ca> (raw)
In-Reply-To: <1224075647.4022.33.camel@galileo.recco.de>
On Wed, Oct 15, 2008 at 03:00:47PM +0200, Wolfgang Ocker wrote:
> The patch allows to specify that an SPI device needs an active high chip
> select.
This look reasonable to me. Anyone else have comments on this binding?
g.
>
> Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
> ---
>
> --- linux-2.6.27-rc7/drivers/of/of_spi.c.of_spi_cshigh 2008-09-22 00:29:55.000000000 +0200
> +++ linux-2.6.27-rc7/drivers/of/of_spi.c 2008-09-29 13:43:06.000000000 +0200
> @@ -61,6 +61,8 @@
> spi->mode |= SPI_CPHA;
> if (of_find_property(nc, "spi-cpol", NULL))
> spi->mode |= SPI_CPOL;
> + if (of_find_property(nc, "spi-cs-high", NULL))
> + spi->mode |= SPI_CS_HIGH;
>
> /* Device speed */
> prop = of_get_property(nc, "spi-max-frequency", &len);
> --- linux-2.6.27-rc7/Documentation/powerpc/booting-without-of.txt.of_spi_cshigh 2008-09-29 14:14:08.000000000 +0200
> +++ linux-2.6.27-rc7/Documentation/powerpc/booting-without-of.txt 2008-09-29 14:24:26.000000000 +0200
> @@ -1917,6 +1917,8 @@
> inverse clock polarity (CPOL) mode
> - spi-cpha - (optional) Empty property indicating device requires
> shifted clock phase (CPHA) mode
> + - spi-cs-high - (optional) Empty property indicating device requires
> + chip select active high
>
> SPI example for an MPC5200 SPI bus:
> spi@f00 {
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2008-10-15 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 13:00 [PATCH] powerpc: SPI: specify chip select active high Wolfgang Ocker
2008-10-15 14:22 ` Grant Likely [this message]
2008-10-15 15:51 ` Anton Vorontsov
2008-10-20 14:52 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081015142228.GD16262@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=weo@reccoware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.