All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: <stable@kernel.org>
Cc: <steven@uplinklabs.net>, <linville@tuxdriver.com>,
	<linux-wireless@vger.kernel.org>
Subject: [PATCH] ath9k: fix oops on trying to hold the wrong spinlock
Date: Thu, 16 Oct 2008 04:12:55 -0700	[thread overview]
Message-ID: <20081016111255.GA5899@tesla> (raw)

This fixes on oops when you get try to send a BA to an 11n AP.
The oops occurred because we were trying to aquire an incorrect
spinlock.

We were trying to hold the wrong spinlock due to a typo
on IEEE80211_BAR_CTL_TID_S's definition. We use this to
compute the tid number and then hold this this tid number's
spinlock.

Tested-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

I don't see this queue'd yet for 2.6.27.2

 drivers/net/wireless/ath9k/core.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath9k/core.h b/drivers/net/wireless/ath9k/core.h
index 80814c9..5b4f1c4 100644
--- a/drivers/net/wireless/ath9k/core.h
+++ b/drivers/net/wireless/ath9k/core.h
@@ -309,7 +309,7 @@ void ath_descdma_cleanup(struct ath_softc *sc,
 #define ATH_RX_TIMEOUT           40      /* 40 milliseconds */
 #define WME_NUM_TID              16
 #define IEEE80211_BAR_CTL_TID_M  0xF000  /* tid mask */
-#define IEEE80211_BAR_CTL_TID_S  2       /* tid shift */
+#define IEEE80211_BAR_CTL_TID_S  12      /* tid shift */
 
 enum ATH_RX_TYPE {
 	ATH_RX_NON_CONSUMED = 0,
-- 
1.5.6.rc2.15.g457bb.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2008-10-16 18:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 11:12 Luis R. Rodriguez [this message]
2008-10-16 21:54 ` [stable] [PATCH] ath9k: fix oops on trying to hold the wrong spinlock Greg KH
2008-10-16 23:12   ` Luis R. Rodriguez
2008-10-16 23:28     ` Greg KH
2008-10-16 23:41       ` Luis R. Rodriguez
  -- strict thread matches above, loose matches on Subject: below --
2008-10-03 22:45 [PATCH 0/3] ath9k: pending patches Luis R. Rodriguez
2008-10-03 22:45 ` [PATCH 1/3] ath9k: kill ath9k's memzero() and use memset() instead Luis R. Rodriguez
2008-10-03 22:45   ` [PATCH 2/3] ath9k: fix oops on trying to hold the wrong spinlock Luis R. Rodriguez
2008-10-05  2:32     ` Luis R. Rodriguez
2008-10-05  7:34       ` [PATCH] " Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081016111255.GA5899@tesla \
    --to=lrodriguez@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=stable@kernel.org \
    --cc=steven@uplinklabs.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.