Re: [PATCH 0/6] Add qdisc->ops->peek() support.

[Jarek Poplawski <jarkao2@gmail.com>]

On Thu, Oct 16, 2008 at 02:38:31PM +0200, Patrick McHardy wrote:
> Jarek Poplawski wrote:
>> So here is my try (I hope I didn't miss Patrick's intentions to much).
>>
>> PATCH 6/6 adds my simple idea not to prevent even nonsense configs.
>> It is optional.
>
> These patches look good to me. About 6/6, I'm still thinking we
> might want to prevent certain kinds of nonsensical configurations
> for simplicity. Its a bit similar to the multiq stuff, a lot of
> these complications came from the fact that non-work-conserving
> qdiscs, which require a global view, are treated similar to work-
> conserving ones. I don't have a good scheme worked out though,
> so for now using your patch seems OK too.
>
>> PS: after this patchset only netem_enqueue() needs qdisc->requeue(),
>> but I hope this won't take too long.
>
> Assuming work-conserving qdiscs are used with netem, the currently
> code will always send out a reorder packet immediately. This behaviour
> is trivial to implement without ->requeue. The problematic case is
> non-work-conserving inner qdiscs, but that doesn't seem important
> at all since you'd usually add it as parent of netem, which still
> works.

Patrick, thanks for the feedback so far. I have to have some break now
so I'll try to respond or redo this, if needed, in the evening.

Jarek P.