From: Andrew Morton <akpm@linux-foundation.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: davem@davemloft.net, alan@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: Make uart_port's ioport "resource_size_t"
Date: Thu, 16 Oct 2008 14:46:45 -0700 [thread overview]
Message-ID: <20081016144645.1c868fc0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081014162621.GA18166@yoda.jdub.homelinux.org>
On Tue, 14 Oct 2008 12:26:21 -0400
Josh Boyer <jwboyer@linux.vnet.ibm.com> wrote:
> Recently uart_port's iobase was changed to be an 'unsigned
> long' to avoid chopping off the upper 32-bits of the
> address on 64-bit CPUs. However, there are CPUs that are
> 32-bit but have a 64-bit address space. This changes
> iobase to be 'resource_size_t' to accommodate those types
> of systems. This also matches what is done for the mapbase
> member of uart_port.
>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>
> ---
>
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index e27f216..cb0185b 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -241,7 +241,7 @@ typedef unsigned int __bitwise__ upf_t;
>
> struct uart_port {
> spinlock_t lock; /* port lock */
> - unsigned long iobase; /* in/out[bwl] */
> + resource_size_t iobase; /* in/out[bwl] */
> unsigned char __iomem *membase; /* read/write[bwl] */
> unsigned int irq; /* irq number */
> unsigned int uartclk; /* base uart clock */
This will of course require that all now-broken printk()s be unbroken.
I spot two in serial_core.c alone.
next prev parent reply other threads:[~2008-10-16 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 16:26 [PATCH] serial: Make uart_port's ioport "resource_size_t" Josh Boyer
2008-10-16 21:46 ` Andrew Morton [this message]
2008-10-16 23:44 ` Josh Boyer
2008-10-17 0:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081016144645.1c868fc0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=davem@davemloft.net \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.