All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: avorontsov@ru.mvista.com, linux-kernel@vger.kernel.org,
	stable@kernel.org
Subject: Re: [patch] gpiolib: fix oops in gpio_get_value_cansleep()
Date: Thu, 16 Oct 2008 17:44:33 -0700	[thread overview]
Message-ID: <200810161744.34005.david-b@pacbell.net> (raw)
In-Reply-To: <20081016161718.e05864da.akpm@linux-foundation.org>

On Thursday 16 October 2008, Andrew Morton wrote:
> > From: David Brownell <dbrownell@users.sourceforge.net>
> > 
> > We can get the following oops from gpio_get_value_cansleep()
> > when a GPIO controller doesn't provide a get() callback:
> 
> We can, but do we? ;)

I think it's unlikely without the sysfs interface.


> iow: is this needed in any -stable release?

The bug has been there since 2.6.25 but nobody else seems
to have reported it.  Is the general policy to fix all
oopses that *could* appear?  I'd send it for 2.6.27-stable,
since that's got the sysfs hooks.  And older kernels if
bug likelihood isn't a major concern.

- Dave
 



  reply	other threads:[~2008-10-17  0:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 15:45 [patch] gpiolib: fix oops in gpio_get_value_cansleep() David Brownell
2008-10-16 16:43 ` Anton Vorontsov
2008-10-16 17:06   ` David Brownell
2008-10-16 17:15     ` Anton Vorontsov
2008-10-16 23:17 ` Andrew Morton
2008-10-17  0:44   ` David Brownell [this message]
2008-10-17  0:54     ` Andrew Morton
2008-10-17  2:45       ` [stable] " Greg KH
2008-10-17  3:00         ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810161744.34005.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=akpm@linux-foundation.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.