From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver. Date: Thu, 16 Oct 2008 14:23:34 -0700 Message-ID: <20081016212334.GV15820@atomide.com> References: <1223964434-5752-1-git-send-email-j-pakaravoor@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:57609 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755196AbYJPVXh (ORCPT ); Thu, 16 Oct 2008 17:23:37 -0400 Content-Disposition: inline In-Reply-To: <1223964434-5752-1-git-send-email-j-pakaravoor@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: David Brownell Cc: linux-omap@vger.kernel.org, Jagadeesh Bhaskar Pakaravoor * Jagadeesh Bhaskar Pakaravoor [081014 11:08]: > The i2c_driver in twl4030-core.c and platform_driver of twl4030-usb.c > both has the name twl4030_driver. This leads to unnecessary confusion. > > So rename the usb platform_driver appropriately to: > twl4030_usb_driver. Dave, is this OK with you? I don't want this to get out of sync with mainline.. Tony > > Signed-off-by: Jagadeesh Bhaskar Pakaravoor > Index: linux-omap-git/drivers/i2c/chips/twl4030-usb.c > =================================================================== > --- linux-omap-git.orig/drivers/i2c/chips/twl4030-usb.c 2008-10-10 20:35:15.000000000 +0530 > +++ linux-omap-git/drivers/i2c/chips/twl4030-usb.c 2008-10-14 11:01:09.785700607 +0530 > @@ -758,7 +758,7 @@ static int __exit twl4030_usb_remove(str > return 0; > } > > -static struct platform_driver twl4030_driver = { > +static struct platform_driver twl4030_usb_driver = { > .probe = twl4030_usb_probe, > .remove = __exit_p(twl4030_remove), > .driver = { > @@ -769,13 +769,13 @@ static struct platform_driver twl4030_dr > > static int __init twl4030_usb_init(void) > { > - return platform_driver_register(&twl4030_driver); > + return platform_driver_register(&twl4030_usb_driver); > } > subsys_initcall(twl4030_usb_init); > > static void __exit twl4030_usb_exit(void) > { > - platform_driver_unregister(&twl4030_driver); > + platform_driver_unregister(&twl4030_usb_driver); > } > module_exit(twl4030_usb_exit); >