From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, jeremy@sgi.com
Subject: Re: [PATCH 1/2] sgiioc4: kill useless address checks
Date: Thu, 16 Oct 2008 21:39:39 +0200 [thread overview]
Message-ID: <200810162139.39612.bzolnier@gmail.com> (raw)
In-Reply-To: <200810152329.20095.sshtylyov@ru.mvista.com>
On Wednesday 15 October 2008, Sergei Shtylyov wrote:
> The driver performs a number of checks on the virtual/physical addresses which
> would always evaluate as true:
>
> - for sgiioc4_init_hwif_ports(), its caller, sgiioc4_ide_setup_pci_device(),
> guarantees that 'ctrl_port' and 'irq_port' parameters are never 0;
>
> - in sgiioc4_read_status(), we always read the IDE status register, so there's
> no need to check the register's address (must be a leftover from the times
> when this function implemented the INB() method);
>
> - in ide_dma_sgiioc4(), 'dma_base' can never be 0 as IOC4_DMA_OFFSET is not 0.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied patches #1-2 (#1 w/ fixed patch description)
next prev parent reply other threads:[~2008-10-16 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 19:29 [PATCH 1/2] sgiioc4: kill useless address checks Sergei Shtylyov
2008-10-16 9:41 ` Sergei Shtylyov
2008-10-16 10:08 ` Sergei Shtylyov
2008-10-16 19:39 ` Bartlomiej Zolnierkiewicz [this message]
2008-12-07 8:03 ` Jeremy Higdon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810162139.39612.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=jeremy@sgi.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.