From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + fat-use-generic_file_llseek-for-directory.patch added to -mm tree Date: Thu, 16 Oct 2008 15:07:24 -0700 Message-ID: <200810162207.m9GM7O2K028050@imap1.linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:45142 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756198AbYJPWH1 (ORCPT ); Thu, 16 Oct 2008 18:07:27 -0400 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org Cc: hirofumi@mail.parknet.co.jp The patch titled fat: use generic_file_llseek() for directory has been added to the -mm tree. Its filename is fat-use-generic_file_llseek-for-directory.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: fat: use generic_file_llseek() for directory From: OGAWA Hirofumi Since fat_dir_ioctl() was already fixed (i.e. called under ->i_mutex), and __fat_readdir() doesn't take BKL anymore. So, BKL for ->llseek() is pointless, and we have to use generic_file_llseek(). Signed-off-by: OGAWA Hirofumi Signed-off-by: Andrew Morton --- fs/fat/dir.c | 1 + 1 file changed, 1 insertion(+) diff -puN fs/fat/dir.c~fat-use-generic_file_llseek-for-directory fs/fat/dir.c --- a/fs/fat/dir.c~fat-use-generic_file_llseek-for-directory +++ a/fs/fat/dir.c @@ -832,6 +832,7 @@ static long fat_compat_dir_ioctl(struct #endif /* CONFIG_COMPAT */ const struct file_operations fat_dir_operations = { + .llseek = generic_file_llseek, .read = generic_read_dir, .readdir = fat_readdir, .ioctl = fat_dir_ioctl, _ Patches currently in -mm which might be from hirofumi@mail.parknet.co.jp are origin.patch fat-document-additional-vfat-mount-options.patch fat-move-fs-vfat-and-fs-msdos-to-fs-fat.patch fat-split-include-msdos_fsh.patch fat-fix-and-cleanup-timestamp-conversion.patch fat-use-generic_file_llseek-for-directory.patch fat-cleanup-fat_parse_long-error-handling.patch fat-improve-fat_hash.patch fat-fix-fat_ent_update_ptr-for-fat12.patch fat-use-fat_detach-in-fat_clear_inode.patch vfat-fix-vfat_find-error-path-in-vfat_lookup.patch fat-fix-cleanup-dcache-handling-for-vfat.patch fat-kill-d_invalidate-in-vfat_lookup.patch fat-cleanup-msdos_lookup.patch fat-cleanup-fat-attribute-stuff.patch fat-fix-attr_ro-in-the-case-of-umask-s_wugo-==-0.patch fat-fix-attr_ro-for-directory.patch fat-fix-_fat_bmap-race.patch fat-add-printf-attribute-to-fat_fs_panic.patch fat-mmu_private-race-fix.patch fat-i_pos-race-fix.patch fat-i_blocks-warning-fix.patch