All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap@vger.kernel.org,
	Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
Subject: Re: [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver.
Date: Thu, 16 Oct 2008 15:08:37 -0700	[thread overview]
Message-ID: <20081016220837.GY15820@atomide.com> (raw)
In-Reply-To: <200810161505.05279.david-b@pacbell.net>

* David Brownell <david-b@pacbell.net> [081016 15:05]:
> On Thursday 16 October 2008, Tony Lindgren wrote:
> > * Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com> [081014 11:08]:
> > > The i2c_driver in twl4030-core.c and platform_driver of twl4030-usb.c
> > > both has the name twl4030_driver. This leads to unnecessary confusion.
> > > 
> > > So rename the usb platform_driver appropriately to:
> > > twl4030_usb_driver.
> > 
> > Dave, is this OK with you? I don't want this to get out of sync with
> > mainline..
> 
> Sure, no problem.  This driver isn't yet in the mainline queue.

OK, pushed.

Tony

> 
> 
> > Tony
> > 
> > > 
> > > Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> > > Index: linux-omap-git/drivers/i2c/chips/twl4030-usb.c
> > > ===================================================================
> > > --- linux-omap-git.orig/drivers/i2c/chips/twl4030-usb.c	2008-10-10 20:35:15.000000000 +0530
> > > +++ linux-omap-git/drivers/i2c/chips/twl4030-usb.c	2008-10-14 11:01:09.785700607 +0530
> > > @@ -758,7 +758,7 @@ static int __exit twl4030_usb_remove(str
> > >  	return 0;
> > >  }
> > >  
> > > -static struct platform_driver twl4030_driver = {
> > > +static struct platform_driver twl4030_usb_driver = {
> > >  	.probe		= twl4030_usb_probe,
> > >  	.remove		= __exit_p(twl4030_remove),
> > >  	.driver		= {
> > > @@ -769,13 +769,13 @@ static struct platform_driver twl4030_dr
> > >  
> > >  static int __init twl4030_usb_init(void)
> > >  {
> > > -	return platform_driver_register(&twl4030_driver);
> > > +	return platform_driver_register(&twl4030_usb_driver);
> > >  }
> > >  subsys_initcall(twl4030_usb_init);
> > >  
> > >  static void __exit twl4030_usb_exit(void)
> > >  {
> > > -	platform_driver_unregister(&twl4030_driver);
> > > +	platform_driver_unregister(&twl4030_usb_driver);
> > >  }
> > >  module_exit(twl4030_usb_exit);
> > >  
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 
> 
> 

      reply	other threads:[~2008-10-16 22:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14  6:07 [PATCH] twl4030-usb: rename twl4030_driver to twl4030_usb_driver Jagadeesh Bhaskar Pakaravoor
2008-10-16 21:23 ` Tony Lindgren
2008-10-16 22:05   ` David Brownell
2008-10-16 22:08     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081016220837.GY15820@atomide.com \
    --to=tony@atomide.com \
    --cc=david-b@pacbell.net \
    --cc=j-pakaravoor@ti.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.