From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH, RFC] ext4: Replace hackish ext4_mb_poll_new_transaction with commit callback
Date: Fri, 17 Oct 2008 11:34:25 +0530 [thread overview]
Message-ID: <20081017060424.GA26192@skywalker> (raw)
In-Reply-To: <1224201763-9637-1-git-send-email-tytso@mit.edu>
On Thu, Oct 16, 2008 at 08:02:43PM -0400, Theodore Ts'o wrote:
> The multiblock allocator needs to be able to release blocks (and issue
> a blkdev discard request) when the transaction which freed those
> blocks is committed. Previously this was done via a polling mechanism
> when blocks are allocated or freed. A much better way of doing things
> is to create a jbd2 callback function and attaching the list of blocks
> to be freed directly to the transaction structure.
Why not use journal commit callback patch from andreas
(MID:20080929201752.GN10950@webber.adilger.int
http://article.gmane.org/gmane.comp.file-systems.ext4/9148)
The patch you sent will allows only one call back to be registered.
-aneesh
next prev parent reply other threads:[~2008-10-17 6:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 0:02 [PATCH, RFC] ext4: Replace hackish ext4_mb_poll_new_transaction with commit callback Theodore Ts'o
2008-10-17 6:04 ` Aneesh Kumar K.V [this message]
2008-10-17 10:02 ` Theodore Tso
2008-10-17 12:25 ` Theodore Tso
2008-10-17 20:27 ` Joel Becker
2008-10-19 22:49 ` Andreas Dilger
2008-10-20 1:13 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081017060424.GA26192@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.