From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SYSFS: Fix return values for sysdev_store_{ulong,int}
Date: Fri, 17 Oct 2008 08:25:33 +0200 [thread overview]
Message-ID: <20081017062533.GZ12131@one.firstfloor.org> (raw)
In-Reply-To: <20081016133530.1024528d.akpm@linux-foundation.org>
On Thu, Oct 16, 2008 at 01:35:30PM -0700, Andrew Morton wrote:
> On Mon, 13 Oct 2008 12:03:03 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > SYSFS: Fix return values for sysdev_store_{ulong,int}
> >
> > Always return the full size instead of the consumed
> > length of the string in sysdev_store_{ulong,int}
> >
> > This avoids EINVAL errors in some echo versions.
>
> That sounds fairly serious. Is this a regression or are those versions
> of echo really ancient, or...?
It's a regression, but it currently only affects the mce sysfs files,
which are the only ones using it. Also the EINVAL is more a cosmetic
issue because the first write will already change the value successfully,
only the second one will fail but not change anything.
-Andi
--
ak@linux.intel.com
prev parent reply other threads:[~2008-10-17 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 10:03 [PATCH] SYSFS: Fix return values for sysdev_store_{ulong,int} Andi Kleen
2008-10-16 20:35 ` Andrew Morton
2008-10-17 6:25 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081017062533.GZ12131@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.