All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Joel Becker <joel.becker@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"Linux-iSCSI.org Target Dev"
	<linux-iscsi-target-dev@googlegroups.com>,
	SCST-Devel <scst-devel@lists.sourceforge.net>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrew Morton <akpm@osdl.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] [ConfigFS]: Allow symbolic links from a SysFS struct kobject source.
Date: Fri, 17 Oct 2008 00:44:53 -0700	[thread overview]
Message-ID: <20081017074453.GA4850@kroah.com> (raw)
In-Reply-To: <1224226555.5556.279.camel@haakon2.linux-iscsi.org>

On Thu, Oct 16, 2008 at 11:55:55PM -0700, Nicholas A. Bellinger wrote:
> Hi Joel, Greg and Co,
> 
> Here is the the first working code for allowing configfs to handle
> symlinks from sysfs struct kobject based code.  Here is the commit:
> passing struct kobject into generic target_core_mod subsystem plugins
> for locating struct block_device and struct scsi_device..  

Um, no.

You are trying to create symlinks dynamically across superblocks and
mount points?  As one of your #warning states, this isn't possible to do
correctly, nor is it even a good idea.

So I'd have to reject this patch, sorry.

What is the problem you are attempting to solve here?

thanks,

greg k-h

  reply	other threads:[~2008-10-17  7:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17  6:55 [PATCH] [ConfigFS]: Allow symbolic links from a SysFS struct kobject source Nicholas A. Bellinger
2008-10-17  7:44 ` Greg KH [this message]
2008-10-17  8:22   ` Nicholas A. Bellinger
2008-10-17 11:32     ` Matthew Wilcox
2008-10-17 19:02       ` Nicholas A. Bellinger
2008-10-17 17:39     ` Greg KH
2008-10-17 19:19       ` Nicholas A. Bellinger
2008-10-17 20:10         ` Greg KH
2008-10-18  2:41           ` Nicholas A. Bellinger
2008-10-17 19:48     ` Joel Becker
2008-10-17 20:03       ` Nicholas A. Bellinger
2008-10-17 20:07       ` Nicholas A. Bellinger
2008-10-17 19:39 ` Joel Becker
2008-10-17 19:50   ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081017074453.GA4850@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=joel.becker@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-iscsi-target-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=scst-devel@lists.sourceforge.net \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.