From: Michael Buesch <mb@bu3sch.de>
To: "Magnus Damm" <magnus.damm@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
linux-kernel <linux-kernel@vger.kernel.org>,
"David Brownell" <david-b@pacbell.net>,
"Piot Skamruk" <piotr.skamruk@gmail.com>,
openwrt-devel@lists.openwrt.org
Subject: Re: [PATCH v3] Add SPI over GPIO driver
Date: Fri, 17 Oct 2008 10:52:54 +0200 [thread overview]
Message-ID: <200810171052.54823.mb@bu3sch.de> (raw)
In-Reply-To: <aec7e5c30810162014w33fe08f2ta2b05cb187770e3a@mail.gmail.com>
On Friday 17 October 2008 05:14:26 Magnus Damm wrote:
> On Mon, Jul 21, 2008 at 4:46 AM, Michael Buesch <mb@bu3sch.de> wrote:
> > This adds a driver that lets you drive an SPI bus over
> > generic GPIO pins.
> >
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> Very useful. Fits my shiny new GPIO implementation for SuperH like a glove.
>
> Michael, as you know, I have some SuperH board code that makes use of
> this driver. Are there any outstanding issues with this driver that I
> can help resolving?
bool cs_activelow should probably be removed from struct spi_gpio_platform_data.
I think cs always is activelow, so we can simply hardcode this in spi_gpio_chipselect()
If you want to do this, please feel free to do so.
I currently don't have the time for this.
The rest of the driver is fine with me.
--
Greetings Michael.
next prev parent reply other threads:[~2008-10-17 8:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 19:46 [PATCH v3] Add SPI over GPIO driver Michael Buesch
2008-10-17 3:14 ` Magnus Damm
2008-10-17 8:52 ` Michael Buesch [this message]
2008-10-17 9:52 ` Magnus Damm
2008-10-17 11:18 ` Michael Buesch
2008-10-18 4:36 ` Andrew Morton
2008-10-18 9:32 ` Michael Buesch
2008-10-18 20:41 ` Piotr Skamruk
2008-10-18 20:54 ` David Brownell
2008-10-20 2:44 ` Magnus Damm
2008-10-20 4:16 ` David Brownell
2008-10-20 9:48 ` Michael Buesch
2008-10-20 4:24 ` [patch 2.6.27-git] spi_gpio driver David Brownell
2008-10-20 9:11 ` [spi-devel-general] " Ben Dooks
[not found] ` <20081020091127.GA4413-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2008-10-20 8:37 ` David Brownell
2008-10-20 8:37 ` [spi-devel-general] " David Brownell
[not found] ` <200810192124.36402.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-10-21 12:40 ` Magnus Damm
2008-10-21 12:40 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810171052.54823.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=openwrt-devel@lists.openwrt.org \
--cc=piotr.skamruk@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.