diff for duplicates of <20081017110945.GA32364@elte.hu> diff --git a/a/1.txt b/N1/1.txt index 8ca2ff6..78bad5d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,17 +1,18 @@ * David Miller <davem@davemloft.net> wrote: -> > net/dccp/options.c: In function 'dccp_parse_options': -> > net/dccp/options.c:67: warning: 'value' may be used uninitialized in +> > net/dccp/options.c: In function 'dccp_parse_options':=20 +> > net/dccp/options.c:67: warning: 'value' may be used uninitialized i= +n=20 > > this function -> -> Known issue, not trivial to fix, gcc is just being incredibly silly +>=20 +> Known issue, not trivial to fix, gcc is just being incredibly silly=20 > here as it can't see all of the control flow. -i just ran into this - do you have any objection against the patch +i just ran into this - do you have any objection against the patch=20 below? -Should we have a cleaner annotation perhaps instead of +Should we have a cleaner annotation perhaps instead of=20 uninitialized_var()? Something like: #define __used __attribute__((used)) @@ -21,20 +22,23 @@ uninitialized_var()? Something like: Ingo ----------> -From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001 -From: Ingo Molnar <mingo@elte.hu> +=46rom d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 200= +1 +=46rom: Ingo Molnar <mingo@elte.hu> Date: Fri, 17 Oct 2008 12:41:30 +0200 Subject: [PATCH] fix warning in net/dccp/options.c MIME-Version: 1.0 -Content-Type: text/plain; charset=utf-8 +Content-Type: text/plain; charset=3Dutf-8 Content-Transfer-Encoding: 8bit fix this warning: - net/dccp/options.c: In function ‘dccp_parse_options’: - net/dccp/options.c:67: warning: ‘value’ may be used uninitialized in this function + net/dccp/options.c: In function =E2=80=98dccp_parse_options=E2=80=99: + net/dccp/options.c:67: warning: =E2=80=98value=E2=80=99 may be used u= +ninitialized in this function -This is a bogus GCC warning. The compiler does not recognize the relation +This is a bogus GCC warning. The compiler does not recognize the relati= +on between "value" and "mandatory" variables: the code flow can ever reach the "out_invalid_option:" label if 'mandatory' is set to 1, and when 'mandatory' is non-zero, we'll always have 'value' initialized. @@ -50,9 +54,11 @@ diff --git a/net/dccp/options.c b/net/dccp/options.c index 0809b63..18dcfb9 100644 --- a/net/dccp/options.c +++ b/net/dccp/options.c -@@ -64,7 +64,7 @@ int dccp_parse_options(struct sock *sk, struct dccp_request_sock *dreq, +@@ -64,7 +64,7 @@ int dccp_parse_options(struct sock *sk, struct dccp_r= +equest_sock *dreq, (dh->dccph_doff * 4); - struct dccp_options_received *opt_recv = &dp->dccps_options_received; + struct dccp_options_received *opt_recv =3D &dp->dccps_options_receive= +d; unsigned char opt, len; - unsigned char *value; + unsigned char *uninitialized_var(value); @@ -60,6 +66,7 @@ index 0809b63..18dcfb9 100644 __be32 opt_val; int rc; -- -To unsubscribe from this list: send the line "unsubscribe linux-ext4" in +To unsubscribe from this list: send the line "unsubscribe linux-wireles= +s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 8ed4a09..bae1d24 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -24,17 +24,18 @@ "\n" "* David Miller <davem@davemloft.net> wrote:\n" "\n" - "> > net/dccp/options.c: In function 'dccp_parse_options': \n" - "> > net/dccp/options.c:67: warning: 'value' may be used uninitialized in \n" + "> > net/dccp/options.c: In function 'dccp_parse_options':=20\n" + "> > net/dccp/options.c:67: warning: 'value' may be used uninitialized i=\n" + "n=20\n" "> > this function\n" - "> \n" - "> Known issue, not trivial to fix, gcc is just being incredibly silly \n" + ">=20\n" + "> Known issue, not trivial to fix, gcc is just being incredibly silly=20\n" "> here as it can't see all of the control flow.\n" "\n" - "i just ran into this - do you have any objection against the patch \n" + "i just ran into this - do you have any objection against the patch=20\n" "below?\n" "\n" - "Should we have a cleaner annotation perhaps instead of \n" + "Should we have a cleaner annotation perhaps instead of=20\n" "uninitialized_var()? Something like:\n" "\n" " #define __used __attribute__((used))\n" @@ -44,20 +45,23 @@ "\tIngo\n" "\n" "---------->\n" - "From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001\n" - "From: Ingo Molnar <mingo@elte.hu>\n" + "=46rom d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 200=\n" + "1\n" + "=46rom: Ingo Molnar <mingo@elte.hu>\n" "Date: Fri, 17 Oct 2008 12:41:30 +0200\n" "Subject: [PATCH] fix warning in net/dccp/options.c\n" "MIME-Version: 1.0\n" - "Content-Type: text/plain; charset=utf-8\n" + "Content-Type: text/plain; charset=3Dutf-8\n" "Content-Transfer-Encoding: 8bit\n" "\n" "fix this warning:\n" "\n" - " net/dccp/options.c: In function \342\200\230dccp_parse_options\342\200\231:\n" - " net/dccp/options.c:67: warning: \342\200\230value\342\200\231 may be used uninitialized in this function\n" + " net/dccp/options.c: In function =E2=80=98dccp_parse_options=E2=80=99:\n" + " net/dccp/options.c:67: warning: =E2=80=98value=E2=80=99 may be used u=\n" + "ninitialized in this function\n" "\n" - "This is a bogus GCC warning. The compiler does not recognize the relation\n" + "This is a bogus GCC warning. The compiler does not recognize the relati=\n" + "on\n" "between \"value\" and \"mandatory\" variables: the code flow can ever reach\n" "the \"out_invalid_option:\" label if 'mandatory' is set to 1, and when\n" "'mandatory' is non-zero, we'll always have 'value' initialized.\n" @@ -73,9 +77,11 @@ "index 0809b63..18dcfb9 100644\n" "--- a/net/dccp/options.c\n" "+++ b/net/dccp/options.c\n" - "@@ -64,7 +64,7 @@ int dccp_parse_options(struct sock *sk, struct dccp_request_sock *dreq,\n" + "@@ -64,7 +64,7 @@ int dccp_parse_options(struct sock *sk, struct dccp_r=\n" + "equest_sock *dreq,\n" " \t\t\t\t\t(dh->dccph_doff * 4);\n" - " \tstruct dccp_options_received *opt_recv = &dp->dccps_options_received;\n" + " \tstruct dccp_options_received *opt_recv =3D &dp->dccps_options_receive=\n" + "d;\n" " \tunsigned char opt, len;\n" "-\tunsigned char *value;\n" "+\tunsigned char *uninitialized_var(value);\n" @@ -83,8 +89,9 @@ " \t__be32 opt_val;\n" " \tint rc;\n" "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-wireles=\n" + "s\" in\n" "the body of a message to majordomo@vger.kernel.org\n" More majordomo info at http://vger.kernel.org/majordomo-info.html -314b54cdee039afcaef9083b177de4e33e0f7be90fdc86b8db5bac490cbc86b0 +728dd2c6fbe197915ec267e32f85a18622c77808d6cebfd487be3efcf6102110
diff --git a/a/1.txt b/N2/1.txt index 8ca2ff6..5b0d40c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -21,7 +21,7 @@ uninitialized_var()? Something like: Ingo ----------> -From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001 +>From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Fri, 17 Oct 2008 12:41:30 +0200 Subject: [PATCH] fix warning in net/dccp/options.c @@ -59,7 +59,3 @@ index 0809b63..18dcfb9 100644 u32 elapsed_time; __be32 opt_val; int rc; --- -To unsubscribe from this list: send the line "unsubscribe linux-ext4" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 8ed4a09..f04539c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,21 +4,21 @@ "Subject\0Re: powerpc allmodconfig\0" "Date\0Fri, 17 Oct 2008 13:09:45 +0200\0" "To\0David Miller <davem@davemloft.net>\0" - "Cc\0akpm@linux-foundation.org" - dan.j.williams@intel.com + "Cc\0bzolnier@gmail.com" + marek.vasut@gmail.com tiwai@suse.de - linux-ext4@vger.kernel.org netdev@vger.kernel.org - linux-ide@vger.kernel.org - bzolnier@gmail.com - marek.vasut@gmail.com - dwmw2@infradead.org - mark.fasheh@oracle.com - ralf@linux-mips.org - mchehab@infradead.org linux-wireless@vger.kernel.org linux-kernel@vger.kernel.org - " linuxppc-dev@ozlabs.org\0" + ralf@linux-mips.org + mark.fasheh@oracle.com + linuxppc-dev@ozlabs.org + linux-ide@vger.kernel.org + akpm@linux-foundation.org + linux-ext4@vger.kernel.org + dwmw2@infradead.org + dan.j.williams@intel.com + " mchehab@infradead.org\0" "\00:1\0" "b\0" "\n" @@ -44,7 +44,7 @@ "\tIngo\n" "\n" "---------->\n" - "From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001\n" + ">From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001\n" "From: Ingo Molnar <mingo@elte.hu>\n" "Date: Fri, 17 Oct 2008 12:41:30 +0200\n" "Subject: [PATCH] fix warning in net/dccp/options.c\n" @@ -81,10 +81,6 @@ "+\tunsigned char *uninitialized_var(value);\n" " \tu32 elapsed_time;\n" " \t__be32 opt_val;\n" - " \tint rc;\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + " \tint rc;" -314b54cdee039afcaef9083b177de4e33e0f7be90fdc86b8db5bac490cbc86b0 +8cf83662a6e04700501004bf68ad7bff90bafbdf23b1c00737e82300e068d461
diff --git a/a/1.txt b/N3/1.txt index 8ca2ff6..5b0d40c 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -21,7 +21,7 @@ uninitialized_var()? Something like: Ingo ----------> -From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001 +>From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Fri, 17 Oct 2008 12:41:30 +0200 Subject: [PATCH] fix warning in net/dccp/options.c @@ -59,7 +59,3 @@ index 0809b63..18dcfb9 100644 u32 elapsed_time; __be32 opt_val; int rc; --- -To unsubscribe from this list: send the line "unsubscribe linux-ext4" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N3/content_digest index 8ed4a09..b3f9f7f 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -44,7 +44,7 @@ "\tIngo\n" "\n" "---------->\n" - "From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001\n" + ">From d917af0bd043eab40d57f79cba9cf7a7b265a205 Mon Sep 17 00:00:00 2001\n" "From: Ingo Molnar <mingo@elte.hu>\n" "Date: Fri, 17 Oct 2008 12:41:30 +0200\n" "Subject: [PATCH] fix warning in net/dccp/options.c\n" @@ -81,10 +81,6 @@ "+\tunsigned char *uninitialized_var(value);\n" " \tu32 elapsed_time;\n" " \t__be32 opt_val;\n" - " \tint rc;\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + " \tint rc;" -314b54cdee039afcaef9083b177de4e33e0f7be90fdc86b8db5bac490cbc86b0 +a1551818a75009a470a4deea4989de3e9bd366cf145e99db43a3843d2d5fa91e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.