From: Tony Lindgren <tony@atomide.com>
To: Sanjeev Premi <premi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] Fix compiler warnings in smartreflex.c
Date: Fri, 17 Oct 2008 15:31:13 -0700 [thread overview]
Message-ID: <20081017223112.GI18573@atomide.com> (raw)
In-Reply-To: <1223646662-22521-1-git-send-email-premi@ti.com>
* Sanjeev Premi <premi@ti.com> [081010 06:51]:
> Fix these compiler warnings:
> smartreflex.c:126: warning: initialization makes integer from pointer without a cast
> smartreflex.c:134: warning: initialization makes integer from pointer without a cast
>
> Refreshed after updates from Felipe.
Pushing.
Tony
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
> arch/arm/mach-omap2/smartreflex.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index e54c0fb..33f604d 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -49,8 +49,8 @@ struct omap_sr {
> u32 opp1_nvalue, opp2_nvalue, opp3_nvalue, opp4_nvalue;
> u32 opp5_nvalue;
> u32 senp_mod, senn_mod;
> - u32 srbase_addr;
> - u32 vpbase_addr;
> + void __iomem *srbase_addr;
> + void __iomem *vpbase_addr;
> };
>
> /* Custom clocks to enable SR specific enable/disable functions. */
> @@ -60,15 +60,15 @@ struct sr_custom_clk {
> struct omap_sr *sr;
> };
>
> -#define SR_REGADDR(offs) (__force void __iomem *)(sr->srbase_addr + offset)
> +#define SR_REGADDR(offs) (sr->srbase_addr + offset)
>
> -static inline void sr_write_reg(struct omap_sr *sr, int offset, u32 value)
> +static inline void sr_write_reg(struct omap_sr *sr, unsigned offset, u32 value)
> {
> __raw_writel(value, SR_REGADDR(offset));
> }
>
> -static inline void sr_modify_reg(struct omap_sr *sr, int offset, u32 mask,
> - u32 value)
> +static inline void sr_modify_reg(struct omap_sr *sr, unsigned offset, u32 mask,
> + u32 value)
> {
> u32 reg_val;
>
> @@ -79,7 +79,7 @@ static inline void sr_modify_reg(struct omap_sr *sr, int offset, u32 mask,
> __raw_writel(reg_val, SR_REGADDR(offset));
> }
>
> -static inline u32 sr_read_reg(struct omap_sr *sr, int offset)
> +static inline u32 sr_read_reg(struct omap_sr *sr, unsigned offset)
> {
> return __raw_readl(SR_REGADDR(offset));
> }
> --
> 1.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-17 22:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 13:51 [PATCH] Fix compiler warnings in smartreflex.c Sanjeev Premi
2008-10-17 22:31 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-10 12:37 Sanjeev Premi
2008-10-10 12:44 ` Felipe Balbi
2008-10-10 12:54 ` Felipe Balbi
2008-10-10 13:09 ` Premi, Sanjeev
2008-10-10 13:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081017223112.GI18573@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.