Re: Build failure w/o mmu notifiers

[Nikola Ciprich <extmaillist@linuxbox.cz>]

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

Hi,
I've been stumbling to same problems building kernel packages for our distro -
I've made small patches which allow enabling MMU notifier and also preempt notifiers
on kernel with KVM disabled (to allow building external always fresh KVM).
I'm attaching those, hope it helps.
Actually, Avi, do You thing souch patches could be pushed upstream? It doesn't
hurt anything to have such a choice no?
If so, I can send git style patches ;)
regards
nik

On Sat, Oct 18, 2008 at 02:17:27AM +0800, Sheng Yang wrote:
> On Fri, Oct 17, 2008 at 07:47:39PM +0200, Alexander Graf wrote:
> >
> > On 17.10.2008, at 19:25, Sheng Yang wrote:
> >
> >> On Fri, Oct 17, 2008 at 06:34:35PM +0200, Alexander Graf wrote:
> >>> Hi,
> >>>
> >>> I'm currently experiencing build failures when CONFIG_MMU_NOTIFIERS  
> >>> is
> >>> not set. Is this intended? If so, it might be nice to put a  
> >>> configure-
> >>> check or #error somewhere to tell the user that enabling mmu  
> >>> notifiers
> >>> became mandatory.
> >>
> >> Yeah, I think it's intended. In fact, it was selected by KVM
> >> , so if you compile a kernel with KVM, I think it would work...
> >
> > Well - it makes it pretty hard to build KVM as an external module (which 
> > I prefer due to many reasons) and I've actually had a problem to find the 
> > option in make menuconfig somewhere - is it even selectable?
> 
> CONFIG_MMU_NOITFIER? No... It's automatically selected, if you select KVM,
> either in-kernel or module. Please refer to arch/x86/kvm/Kconfig.
> --
> regards
> Yang, Sheng
> >
> > Alex
> >
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz
-------------------------------------

[-- Attachment #2: linux-2.6.25-enable-preempt-notifiers.diff --]
[-- Type: text/plain, Size: 684 bytes --]

diff -Naur linux-2.6.25/init/Kconfig linux-2.6.25-enable-preempt-notifiers/init/Kconfig
--- linux-2.6.25/init/Kconfig	2008-06-10 02:51:26.000000000 -0400
+++ linux-2.6.25-enable-preempt-notifiers/init/Kconfig	2008-06-10 03:09:18.000000000 -0400
@@ -800,6 +800,11 @@
 	  /proc/kpagecount, and /proc/kpageflags. Disabling these
           interfaces will reduce the size of the kernel by approximately 4kb.
 
+config PREEMPT_NOTIFIERS
+	bool "Enable preempt notifiers"
+	help
+	  Enable preempt notifiers
+
 endmenu		# General setup
 
 config SLABINFO
@@ -913,9 +918,6 @@
 
 source "block/Kconfig"
 
-config PREEMPT_NOTIFIERS
-	bool
-
 config CLASSIC_RCU
 	def_bool !PREEMPT_RCU
 	help

[-- Attachment #3: linux-2.6.27-enable-mmu-notifier.diff --]
[-- Type: text/plain, Size: 373 bytes --]

diff -Naur linux-2.6.27/mm/Kconfig linux-2.6.27-enable-mmu-notifier/mm/Kconfig
--- linux-2.6.27/mm/Kconfig	2008-10-10 00:13:53.000000000 +0200
+++ linux-2.6.27-enable-mmu-notifier/mm/Kconfig	2008-10-12 15:10:21.000000000 +0200
@@ -207,4 +207,7 @@
 	depends on !ARCH_NO_VIRT_TO_BUS
 
 config MMU_NOTIFIER
-	bool
+	bool "Enable MMU notifier"
+	help
+	  Enable MMU notifier
+