diff for duplicates of <20081018152745.GA32642@dmt.cnet> diff --git a/a/1.txt b/N1/1.txt index 5147679..befb5ad 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,8 +15,9 @@ On Wed, Oct 15, 2008 at 09:47:24PM +0800, Zhang, Xiantao wrote: > vcpu->arch.ht_active = 0; > > + if (test_and_clear_bit(KVM_REQ_UNHALT, &vcpu->requests)) -> + if (vcpu->arch.mp_state = KVM_MP_STATE_HALTED) -> + vcpu->arch.mp_state > + KVM_MP_STATE_RUNNABLE; +> + if (vcpu->arch.mp_state == KVM_MP_STATE_HALTED) +> + vcpu->arch.mp_state = +> + KVM_MP_STATE_RUNNABLE; > + up_read(&vcpu->kvm->slots_lock); You should release slots_lock when blocking via kvm_vcpu_block(). diff --git a/a/content_digest b/N1/content_digest index e0e3b70..bc4177e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,12 @@ "ref\042DFA526FC41B1429CE7279EF83C6BDC01B47EA5@pdsmsx415.ccr.corp.intel.com\0" "From\0Marcelo Tosatti <mtosatti@redhat.com>\0" "Subject\0Re: kvm/ia64: Fix halt emulation logic.\0" - "Date\0Sat, 18 Oct 2008 15:27:45 +0000\0" - "To\0kvm-ia64@vger.kernel.org\0" + "Date\0Sat, 18 Oct 2008 13:27:45 -0200\0" + "To\0Zhang" + " Xiantao <xiantao.zhang@intel.com>\0" + "Cc\0avi <avi@redhat.com>" + kvm-ia64@vger.kernel.org + " kvm@vger.kernel.org\0" "\00:1\0" "b\0" "Hi Xiantao,\n" @@ -22,8 +26,9 @@ "> \t\tvcpu->arch.ht_active = 0;\n" "> \n" "> +\t\tif (test_and_clear_bit(KVM_REQ_UNHALT, &vcpu->requests))\n" - "> +\t\t\tif (vcpu->arch.mp_state = KVM_MP_STATE_HALTED)\n" - "> +\t\t\t\tvcpu->arch.mp_state > +\t\t\t\t\tKVM_MP_STATE_RUNNABLE;\n" + "> +\t\t\tif (vcpu->arch.mp_state == KVM_MP_STATE_HALTED)\n" + "> +\t\t\t\tvcpu->arch.mp_state =\n" + "> +\t\t\t\t\tKVM_MP_STATE_RUNNABLE;\n" "> +\t\tup_read(&vcpu->kvm->slots_lock);\n" "\n" "You should release slots_lock when blocking via kvm_vcpu_block().\n" @@ -33,4 +38,4 @@ "BTW, none of the data structures in this section of code should be\n" protected by slots_lock? -f2848cd0182f33491d807eef080b565d63564ec2d943715f474d3c91a3a7dd66 +a2e2fcb2dd30206a0358af721da919e3d9b20bd58a6a9b35469bad9f4f18149f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.