Re: [PATCH] omap: Add basic support for Pandora handheld console

[Tony Lindgren <tony@atomide.com>]

* Grazvydas Ignotas <notasas@gmail.com> [081018 07:45]:
> This patch adds support for for basic features: nand, uarts, i2c,
> mmc, rtc, and usb. Also includes defconfig.

Cool, one question below.

> --- /dev/null
> +++ b/arch/arm/mach-omap2/board-omap3pandora.c

<snip>

> +static struct omap_uart_config omap3pandora_uart_config __initdata = {
> +	.enabled_uarts	= ((1 << 0) | (1 << 1) | (1 << 2)),
> +};

Are all the uarts really in use?

Does pandora have a real serial port for debugging?

Not that it matters at this point, but you'll want to have only
the serial ports that you really need enabled, as their clocks block
deeper sleep states.

In general, the short term plan is to change the serial port clocks
only to be enabled during start up if console=ttyS is specified on cmdline.

Regards,

Tony