All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair John Strachan <alistair@devzero.co.uk>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] abituguru3: Please send .. to the abituguru3 (see
Date: Sun, 19 Oct 2008 19:53:26 +0000	[thread overview]
Message-ID: <200810192053.26915.alistair@devzero.co.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.0810191251550.19058@p34.internal.lan>

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

On Sunday 19 October 2008 17:54:15 Justin Piszcz wrote:
> Kernel: 2.6.27.2:
> [   10.242065] abituguru3: found Abit uGuru3, motherboard ID: 0016
> [   10.242105] abituguru3: this motherboard was not detected using DMI.
> Please send the output of "dmidecode" to the abituguru3 maintainer(see
> MAINTAINERS)
>
> Motherboard: AW9D-MAX as shown below.
>
> DMI Decode:
[snip]
>  	Product Name: AW9D-MAX       (Intel i975-ICH7)

The spaces are a somewhat worrying (Abit haven't done this on other boards I 
have DMI information for), but assuming they're constant through all BIOS 
revisions the attached patch should be safe.

(In the longer term it might be safer to only match the board product name, 
and ignore the chipset information. I'll do this if the need arises.)

Please test the attached patch. I'll resubmit a cleaned up version if you can 
verify that the kernel message disappears and your sensors still work.

-- 
Cheers,
Alistair.

[-- Attachment #2: aw9d-max-dmi-detection.diff --]
[-- Type: text/x-patch, Size: 543 bytes --]

diff --git a/drivers/hwmon/abituguru3.c b/drivers/hwmon/abituguru3.c
index d9e7a49..ff6aad8 100644
--- a/drivers/hwmon/abituguru3.c
+++ b/drivers/hwmon/abituguru3.c
@@ -402,7 +402,7 @@ static const struct abituguru3_motherboard_info abituguru3_motherboards[] = {
 		{ "AUX3 Fan",		36, 2, 60, 1, 0 },
 		{ NULL, 0, 0, 0, 0, 0 } }
 	},
-	{ 0x0016, NULL /* AW9D-MAX, need DMI string */, {
+	{ 0x0016, "AW9D-MAX       (Intel i975-ICH7)", {
 		{ "CPU Core",		 0, 0, 10, 1, 0 },
 		{ "DDR2",		 1, 0, 20, 1, 0 },
 		{ "DDR2 VTT",		 2, 0, 10, 1, 0 },

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2008-10-19 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-19 16:54 [lm-sensors] abituguru3: Please send .. to the abituguru3 (see Justin Piszcz
2008-10-19 19:53 ` Alistair John Strachan [this message]
2008-10-20  6:48 ` Jean Delvare
2008-10-20 15:10 ` Justin Piszcz
2008-10-20 16:24 ` Alistair John Strachan
2008-10-20 18:14 ` Justin Piszcz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810192053.26915.alistair@devzero.co.uk \
    --to=alistair@devzero.co.uk \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.