From: Jon Smirl <jonsmirl@gmail.com>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] Format string bug in drivers/of/of_i2c.c
Date: Mon, 20 Oct 2008 08:13:15 -0400 [thread overview]
Message-ID: <20081020121315.10428.10730.stgit@terra> (raw)
Format string bug. Not exploitable, as this is only writable by root,
but worth fixing all the same.
See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b
---
drivers/of/of_i2c.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index 6a98dc8..24bbef7 100644
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
info.addr = *addr;
- request_module(info.type);
+ request_module("%s", info.type);
result = i2c_new_device(adap, &info);
if (result == NULL) {
next reply other threads:[~2008-10-20 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 12:13 Jon Smirl [this message]
2008-10-21 2:52 ` [PATCH] Format string bug in drivers/of/of_i2c.c Benjamin Herrenschmidt
2008-10-21 2:57 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020121315.10428.10730.stgit@terra \
--to=jonsmirl@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.