From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109AbYJTNak (ORCPT ); Mon, 20 Oct 2008 09:30:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751715AbYJTNac (ORCPT ); Mon, 20 Oct 2008 09:30:32 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:44749 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbYJTNac (ORCPT ); Mon, 20 Oct 2008 09:30:32 -0400 Date: Mon, 20 Oct 2008 15:30:03 +0200 From: Ingo Molnar To: Mathieu Desnoyers Cc: Lai Jiangshan , Linux Kernel Mailing List Subject: Re: [PATCH tip/tracing/markers] markers: simplify marker_set_format() Message-ID: <20081020133003.GA27656@elte.hu> References: <48F59425.40601@cn.fujitsu.com> <20081015134416.GA29281@Krystal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081015134416.GA29281@Krystal> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mathieu Desnoyers wrote: > * Lai Jiangshan (laijs@cn.fujitsu.com) wrote: > > > > current marker_set_format() is complex this patch simplify it, > > and decrease the overhead of marker_update_probes(). > > > > Yep, I think I did put the format string after the name \0, which was > rather tricky. I agree that such change makes the code more readable at > the expense of doing 2 allocations per marker rather than one, but > readability might be a good thing here. > > Thanks ! > > Acked-by: Mathieu Desnoyers applied to tip/tracing/markers, thanks! Ingo