From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Sheng" Subject: Re: [PATCH 0/4] Enable MSI support for KVM VT-d Date: Mon, 20 Oct 2008 13:39:32 +0800 Message-ID: <200810201339.32931.sheng.yang@intel.com> References: <> <48FB3316.7050109@redhat.com> <42DFA526FC41B1429CE7279EF83C6BDC01B48959@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "kvm@vger.kernel.org" , "Han, Weidong" , "Kay, Allen M" To: "Zhang, Xiantao" Return-path: Received: from mga09.intel.com ([134.134.136.24]:34436 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbYJTFlC (ORCPT ); Mon, 20 Oct 2008 01:41:02 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01B48959@pdsmsx415.ccr.corp.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Monday 20 October 2008 12:09:20 Zhang, Xiantao wrote: > Avi Kivity wrote: > > Sheng Yang wrote: > >> Hi, Avi > >> > >> This patchset enable MSI support for KVM VT-d. > >> > >> And here are only kernel space ones. The third patch would go to > >> also goto x86 upstream. > >> > >> The userspace code would looks like this: > >> > >> assigned_irq_data.guest_msi_addr = *(uint32_t *)(d->msi_cap + 4); > >> assigned_irq_data.guest_msi_data = *(uint16_t *)(d->msi_cap + 8); > >> assigned_irq_data.flags |= KVM_DEV_IRQ_ASSIGN_ENABLE_MSI; > >> r = kvm_assign_irq(kvm_context, &assigned_irq_data); > >> > >> I've test the patchset with some userspace hack, it works well. > > > > Can you resend this patch with all the updates, as well as the > > userspace changes? > > Maybe Sheng need to make it work on kvm/ia64, and at least the changes > can't break ia64 side. Xiantao > Yes, I would ensure that won't break ia64. I would repost the patchset soon. But Avi, for the userspace, the Amit's patch still not checked in, so I haven't written a complete version because of lacking code base. I only got a experiment patch by hand, expose MSI cap to guest and enable MSI when guest wrote MSI enable bit. Well, I prefer to give you a complete version after Amit's patch is there. (I will conclude the change of userspace in the first mail). -- regards Yang, Sheng