From: Arjan van de Ven <arjan@infradead.org>
To: Dave Airlie <airlied@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Brandon Philips <bphilips@suse.de>,
zhenyu.z.wang@intel.com, jbarnes@virtuousgeek.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] intel-agp: Avoid oops for G33 on 1MB stolen case
Date: Mon, 20 Oct 2008 14:52:07 -0700 [thread overview]
Message-ID: <20081020145207.15843ca6@infradead.org> (raw)
In-Reply-To: <1224539086.3656.6.camel@optimus>
On Tue, 21 Oct 2008 07:44:46 +1000
Dave Airlie <airlied@redhat.com> wrote:
> > + printk(KERN_WARNING PFX
> > > + "Warning: G33 chipset
> > > with 1MB"
> > > + " allocated. Older X.org
> > > Intel drivers"
> > > + " will not work.\n");
> > > + WARN_ON(1);
> > > + }
> > > gtt_entries = MB(1) - KB(size);
> > > break;
> > > case I855_GMCH_GMS_STOLEN_4M:
> >
> > Is the bug which this patch addresses present in the 2.6.27 kernel?
> >
>
> I've been a bit wary about this patch, but on re-review I suppose it
> should be fine. We'll just get WARN_ONs in places we don't really want
> them, and I'm sure Arjan will come complaining about them from
> kerneloops.
>
the patch is not so nice for this;
the printk+WARN_ON() really should be using WARN() instead; that also
allows me to filter these guys out easily if needed.
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-10-20 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 22:58 [PATCH] intel-agp: Avoid oops for G33 on 1MB stolen case Brandon Philips
2008-10-20 21:21 ` Andrew Morton
2008-10-20 21:44 ` Dave Airlie
2008-10-20 21:52 ` Arjan van de Ven [this message]
2008-10-29 4:41 ` Brandon Philips
2008-10-29 5:22 ` [PATCH v2] " Brandon Philips
2008-10-29 5:23 ` [PATCH] " Brandon Philips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020145207.15843ca6@infradead.org \
--to=arjan@infradead.org \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bphilips@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.