Fwd: Re: [rtc-linux] [patch 2/3] rtc-twl4030 driver

Fwd: Re: [rtc-linux] [patch 2/3] rtc-twl4030 driver

[David Brownell]

Note the MODULE_AUTHOR comment from Alessandro ... anyone
want to fess up?  :)

GIT history suggests  Dmitry Krivoschekov did the original
patch, Alexandre Rusev morphed some TI code into the RTC
framework, and some anonymous TI person started the work.
But I'm not sure I'd trust those inferences.


----------  Forwarded Message  ----------

Subject: Re: [rtc-linux] [patch 2/3] rtc-twl4030 driver
Date: Saturday 18 October 2008
From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: rtc-linux@googlegroups.com

On Fri, 17 Oct 2008 19:15:08 -0700
David Brownell <david-b@pacbell.net> wrote:

> From: David Brownell <dbrownell@users.sourceforge.net>
> 
> This adds a driver for the RTC inside the TWL4030 multi-function device.
> It's a fairly basic RTC, with a wake-capable alarm.
> 
> Note that many of the pre-release Overo boards now in circulation can't
> effectively use this RTC, because of a wiring error that puts its TWL
> chip into "secure" mode.  (As in "secure yourself against tampering".)
> This isn't an issue on other OMAP3 boards now supported in mainline,
> such as Beagle and Labrador.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

  Acked-by: Alessandro Zummo <a.zummo@towertech.it>

 I'd love to see an email in MODULE_AUTHOR
-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


-------------------------------------------------------

Re: Fwd: Re: [rtc-linux] [patch 2/3] rtc-twl4030 driver

[Samuel Ortiz]

On Sat, Oct 18, 2008 at 12:13:18PM -0700, David Brownell wrote:
> Note the MODULE_AUTHOR comment from Alessandro ... anyone
> want to fess up?  :)
> 
> GIT history suggests  Dmitry Krivoschekov did the original
> patch, Alexandre Rusev morphed some TI code into the RTC
> framework, and some anonymous TI person started the work.
I am pushing this code without MODULE_AUTHOR for now.
I agree with Alessandro it would be nice to have it, but only if it's someone
that could actually maintain it somehow. Are Dmitry or/and Alexandre good
candidates for that ?

Cheers,
Samuel.

> But I'm not sure I'd trust those inferences.
>
> 
> ----------  Forwarded Message  ----------
> 
> Subject: Re: [rtc-linux] [patch 2/3] rtc-twl4030 driver
> Date: Saturday 18 October 2008
> From: Alessandro Zummo <alessandro.zummo@towertech.it>
> To: rtc-linux@googlegroups.com
> 
> On Fri, 17 Oct 2008 19:15:08 -0700
> David Brownell <david-b@pacbell.net> wrote:
> 
> > From: David Brownell <dbrownell@users.sourceforge.net>
> > 
> > This adds a driver for the RTC inside the TWL4030 multi-function device.
> > It's a fairly basic RTC, with a wake-capable alarm.
> > 
> > Note that many of the pre-release Overo boards now in circulation can't
> > effectively use this RTC, because of a wiring error that puts its TWL
> > chip into "secure" mode.  (As in "secure yourself against tampering".)
> > This isn't an issue on other OMAP3 boards now supported in mainline,
> > such as Beagle and Labrador.
> > 
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
>   Acked-by: Alessandro Zummo <a.zummo@towertech.it>
> 
>  I'd love to see an email in MODULE_AUTHOR
> -- 
> 
>  Best regards,
> 
>  Alessandro Zummo,
>   Tower Technologies - Torino, Italy
> 
>   http://www.towertech.it
> 
> 
> -------------------------------------------------------

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: Fwd: Re: [rtc-linux] [patch 2/3] rtc-twl4030 driver

[David Brownell]

On Monday 20 October 2008, Samuel Ortiz wrote:
> I am pushing this code without MODULE_AUTHOR for now.
> I agree with Alessandro it would be nice to have it, but only if it's someone
> that could actually maintain it somehow. Are Dmitry or/and Alexandre good
> candidates for that ?

I won't speak for them ...

The OMAP community has, so far, tended to be fairly
good about pitching in to fix things that break; so
there may be less of a worry there.  I also know that
TI is trying to be a bit more "in the loop" with its
staff and mainline, so that should help a bit too.

Anyway, this driver "Just Works", so nothing else
could go wrong.  ;)

- Dave

p.s. I just noticed a boatload of genirq patches
     go upstream ... I suspect that at least the
     reference to NR_IRQS in that one patch will
     need to change.

Re: Fwd: Re: [rtc-linux] [patch 2/3] rtc-twl4030 driver

[Samuel Ortiz]

On Mon, Oct 20, 2008 at 03:51:38PM -0700, David Brownell wrote:
> On Monday 20 October 2008, Samuel Ortiz wrote:
> > I am pushing this code without MODULE_AUTHOR for now.
> > I agree with Alessandro it would be nice to have it, but only if it's someone
> > that could actually maintain it somehow. Are Dmitry or/and Alexandre good
> > candidates for that ?
> 
> I won't speak for them ...
> 
> The OMAP community has, so far, tended to be fairly
> good about pitching in to fix things that break; so
> there may be less of a worry there.  I also know that
> TI is trying to be a bit more "in the loop" with its
> staff and mainline, so that should help a bit too.
> 
> Anyway, this driver "Just Works", so nothing else
> could go wrong.  ;)
I'm reassured ;-)

 
> - Dave
> 
> p.s. I just noticed a boatload of genirq patches
>      go upstream ... I suspect that at least the
>      reference to NR_IRQS in that one patch will
>      need to change.
You mean the NR_IRQS reference from the twl4030 irq update patch ?
I just applied it to my mfd tree, which is built on top of Linus latest git,
and it seemed to at least build fine.
I'm planning to send the last mfd pull request tomorrow, so if you have some
additional fixes, please send them by then.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: Fwd: Re: [rtc-linux] [patch 2/3] rtc-twl4030 driver

[David Brownell]

On Monday 20 October 2008, Samuel Ortiz wrote:
> You mean the NR_IRQS reference from the twl4030 irq update patch ?
> I just applied it to my mfd tree, which is built on top of Linus latest git,
> and it seemed to at least build fine.

Yeah, that one.  Evidently prep for some new "sparse IRQs"
infrastructure, which ought to help shrink the 400+ irq_desc
structs on OMAP ... over 400, mostly unused.

If it builds, I'm expecting that when the sparse stuff merges,
that NR_IRQS will morph to nr_irqs.  ;)


> I'm planning to send the last mfd pull request tomorrow, so if you have some
> additional fixes, please send them by then.

None from me.  Thanks for getting this into 2.6.28-rc ...
seems like this wiill be a good base to merge other "child"
drivers (like the USB transceiver) and support for the
high speed MMC/SD driver.

- Dave