From: Jens Axboe <jens.axboe@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
oomichi@mxs.nes.nec.co.jp
Subject: Re: [PATCH] Fix kexec compile error, undeclared 'vmlist'
Date: Tue, 21 Oct 2008 12:54:05 +0200 [thread overview]
Message-ID: <20081021105404.GD22217@kernel.dk> (raw)
In-Reply-To: <20081021105228.GC22217@kernel.dk>
On Tue, Oct 21 2008, Jens Axboe wrote:
> Hi,
>
> Current -git fails to compile, at least on ppc:
>
> kernel/kexec.c: In function 'crash_save_vmcoreinfo_init':
> kernel/kexec.c:1374: error: 'vmlist' undeclared (first use in this function)
> kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
> kernel/kexec.c:1374: error: for each function it appears in.)
> kernel/kexec.c:1410: error: invalid use of undefined type 'struct vm_struct'
>
> It's missing a vmalloc.h include, introduced by
> acd99dbf54020f5c80b9aa2f2ea86f43cb285b02.
>
> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 777ac45..ac0fde7 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -30,6 +30,7 @@
> #include <linux/pm.h>
> #include <linux/cpu.h>
> #include <linux/console.h>
> +#include <linux/vmalloc.h>
>
> #include <asm/page.h>
> #include <asm/uaccess.h>
So this was already fixed and pushed out by Tony, so nevermind the extra
noise. Apparently I had pulled this morning just before, so missed the
last few changes.
--
Jens Axboe
prev parent reply other threads:[~2008-10-21 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 10:52 [PATCH] Fix kexec compile error, undeclared 'vmlist' Jens Axboe
2008-10-21 10:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021105404.GD22217@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oomichi@mxs.nes.nec.co.jp \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.