From: Andrew Morton <akpm@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: torvalds@linux-foundation.org, paulmck@us.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] byteorder: remove direct includes of linux/byteorder/swab[b].h
Date: Tue, 21 Oct 2008 13:15:34 -0700 [thread overview]
Message-ID: <20081021131534.7c084fdb.akpm@linux-foundation.org> (raw)
In-Reply-To: <1224523418.31861.4.camel@brick>
On Mon, 20 Oct 2008 10:23:38 -0700
Harvey Harrison <harvey.harrison@gmail.com> wrote:
> A consolidated implementation will provide this generically through
> asm/byteorder, remove direct includes to avoid breakage when the
> changeover to the new implementation occurs.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Andrew, this hunk seems to have been lost when you sent it to Linus, it's possible
> you applied this on top of the -next tree where this file has moved, but the tests
> tree hasn't been pulled yet.
>
> The rest of the patch went into mainline as 1d8cca44b6a244b7e378546d719041819049a0f9
>
Grump. It happens sometimes. People putting stuff into linux-next and
then not merging it into the next kernel.
>
> kernel/rcutorture.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> index 90b5b12..85cb905 100644
> --- a/kernel/rcutorture.c
> +++ b/kernel/rcutorture.c
> @@ -42,10 +42,10 @@
> #include <linux/freezer.h>
> #include <linux/cpu.h>
> #include <linux/delay.h>
> -#include <linux/byteorder/swabb.h>
> #include <linux/stat.h>
> #include <linux/srcu.h>
> #include <linux/slab.h>
> +#include <asm/byteorder.h>
Should this be linux/byteorder.h? (Which weirdly doesn't include
asm/byteorder.h).
next prev parent reply other threads:[~2008-10-21 20:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:23 [PATCH] byteorder: remove direct includes of linux/byteorder/swab[b].h Harvey Harrison
2008-10-21 20:15 ` Andrew Morton [this message]
2008-10-21 20:37 ` Harvey Harrison
2008-10-22 0:43 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021131534.7c084fdb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.