All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Rick Jones <rick.jones2@hp.com>,
	David Miller <davem@davemloft.net>,
	jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: skb recycling
Date: Tue, 21 Oct 2008 13:38:11 -0700	[thread overview]
Message-ID: <20081021133811.68bd5ce1@extreme> (raw)
In-Reply-To: <48FE386F.8090706@cosmosbay.com>

On Tue, 21 Oct 2008 22:15:43 +0200
Eric Dumazet <dada1@cosmosbay.com> wrote:

> Rick Jones a écrit :
> > David Miller wrote:
> >> From: Stephen Hemminger <shemminger@vyatta.com>
> >> Date: Mon, 20 Oct 2008 19:09:22 -0700
> >>
> >>
> >>> Add support for recycling tx buffers into receive buffers.
> >>> This is experimental at this point.
> >>>
> >>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> >>
> >>
> >> Experimental, but do you have any performance data at all?
> >> Just curious...
> > 
> > I've not had a good emily litella moment all day so I'll ask - is there 
> > really that much in the way of suitable skb's which are completely free 
> > after transmit completion?
> 
> Or, if we take another way, say a VOIP RTP machine sends and receive 20.000
>  packets per second, each being 200 bytes long, are transmited packets
> correctly sized at sendto() time to be candidates for recycling ?

No. Most locally generate packets aren't going to be right size because
they will be too small, cloned or fragmented.  It really only helps when forwarding.

  reply	other threads:[~2008-10-21 20:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21  2:09 [PATCH] sky2: skb recycling Stephen Hemminger
2008-10-21  5:18 ` David Miller
2008-10-21 19:59   ` Rick Jones
2008-10-21 20:15     ` Eric Dumazet
2008-10-21 20:38       ` Stephen Hemminger [this message]
2008-10-22 23:58         ` Rick Jones
2008-10-23  0:05           ` Stephen Hemminger
2008-10-23  0:17             ` Rick Jones
2008-10-21  5:54 ` Eric Dumazet
2008-10-21  8:25   ` Robert Olsson
2008-10-21  8:49     ` Terry
2008-10-21 12:17       ` Robert Olsson
2008-10-21 12:34         ` Terry
2008-10-21 12:42         ` Eric Dumazet
2008-10-21 13:04           ` Robert Olsson
2008-10-21  9:53     ` Eric Dumazet
2008-10-21 11:58       ` Robert Olsson
2008-10-23  5:28       ` David Miller
2008-10-21 15:09   ` Stephen Hemminger
2008-10-22 11:03 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081021133811.68bd5ce1@extreme \
    --to=shemminger@vyatta.com \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.