From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] quota: Remove bogus 'optimization' in check_idq() and check_bdq()
Date: Tue, 21 Oct 2008 10:29:57 -0700 [thread overview]
Message-ID: <20081021172956.GB10060@mail.oracle.com> (raw)
In-Reply-To: <1224523440201-git-send-email-jack@suse.cz>
On Mon, Oct 20, 2008 at 07:23:36PM +0200, Jan Kara wrote:
> Checks like <= 0 for an unsigned type do not make much sence. The value
> could be only 0 and that does not happen often enough for the check
> to be worth it.
Why not worth it? Certainly the '<' isn't valid, but is it even
possible to call these functions with 0? I don't know enough to answer
that, but I'm wondering if it should BUG_ON(inodes == 0). If not, what
happens after this change? Obviously inodes==0 means the quota doesn't
change, but could they get a soft warning they wouldn't get before?
Joel
--
Life's Little Instruction Book #222
"Think twice before burdening a friend with a secret."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-10-21 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:23 [Ocfs2-devel] [PATCH] quota: Remove bogus 'optimization' in check_idq() and check_bdq() Jan Kara
2008-10-21 17:29 ` Joel Becker [this message]
2008-10-21 19:13 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021172956.GB10060@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.