From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Assign feature bits and system inodes to quota feature and quota files
Date: Tue, 21 Oct 2008 13:43:18 -0700 [thread overview]
Message-ID: <20081021204318.GG2871@mail.oracle.com> (raw)
In-Reply-To: <1224523443220-git-send-email-jack@suse.cz>
On Mon, Oct 20, 2008 at 07:23:55PM +0200, Jan Kara wrote:
> Signed-off-by: Jan Kara <jack@suse.cz>
This patch actually looks fine except for one thing:
> diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
> index 4f61985..bb41c6a 100644
> --- a/fs/ocfs2/ocfs2_fs.h
> +++ b/fs/ocfs2/ocfs2_fs.h
> @@ -91,7 +91,9 @@
> | OCFS2_FEATURE_INCOMPAT_INLINE_DATA \
> | OCFS2_FEATURE_INCOMPAT_EXTENDED_SLOT_MAP \
> | OCFS2_FEATURE_INCOMPAT_USERSPACE_STACK)
> -#define OCFS2_FEATURE_RO_COMPAT_SUPP OCFS2_FEATURE_RO_COMPAT_UNWRITTEN
> +#define OCFS2_FEATURE_RO_COMPAT_SUPP (OCFS2_FEATURE_RO_COMPAT_UNWRITTEN \
> + | OCFS2_FEATURE_RO_COMPAT_USRQUOTA \
> + | OCFS2_FEATURE_RO_COMPAT_GRPQUOTA)
The hunk turning on support should be the very last patch in the
series. It doesn't matter right now as you are working on it, but when
we go to upstream we'll want all the support in place before we turn it
on.
The rest of the patch - defining the bits and the system files,
etc, is just fine.
Joel
--
"People with narrow minds usually have broad tongues."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-10-21 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:23 [Ocfs2-devel] [PATCH] ocfs2: Assign feature bits and system inodes to quota feature and quota files Jan Kara
2008-10-21 20:43 ` Joel Becker [this message]
2008-10-22 12:02 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021204318.GG2871@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.