diff for duplicates of <200810212326.10278.rusty@rustcorp.com.au> diff --git a/a/1.txt b/N1/1.txt index 5a01d40..9977a2c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,13 +8,13 @@ On Tuesday 21 October 2008 04:03:37 Mike Travis wrote: 1) I like the name in this context: it's a beacon of sanity after NR_CPUS and nr_cpu_ids. But it's not so clearly a win when general code uses it: - if (cpumask_first(mymask) = nr_cpumask_bits) ... + if (cpumask_first(mymask) == nr_cpumask_bits) ... vs: - if (cpumask_first(mymask) = nr_cpu_ids) ... + if (cpumask_first(mymask) == nr_cpu_ids) ... -2) This breaks anyone who tests that the iterators etc. return = nr_cpu_ids. +2) This breaks anyone who tests that the iterators etc. return == nr_cpu_ids. One of the other patches tried to change them from NR_CPUS to nr_cpu_ids, that should now be revisited & reaudited. diff --git a/a/content_digest b/N1/content_digest index 6ca302b..59c40e4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,26 +2,26 @@ "ref\020081020170322.090531000@polaris-admin.engr.sgi.com\0" "From\0Rusty Russell <rusty@rustcorp.com.au>\0" "Subject\0Re: [PATCH 18/35] cpumask: add nr_cpumask_bits\0" - "Date\0Tue, 21 Oct 2008 12:26:07 +0000\0" + "Date\0Tue, 21 Oct 2008 23:26:07 +1100\0" "To\0Mike Travis <travis@sgi.com>\0" - "Cc\0Ingo Molnar <mingo@elte.hu>" - Andi Kleen <andi@firstfloor.org> - Andrew Morton <akpm@linux-foundation.org> - davej@codemonkey.org.uk - David Miller <davem@davemloft.net> - Eric Dumazet <dada1@cosmosbay.com> - Jack Steiner <steiner@sgi.com> + "Cc\0davej@codemonkey.org.uk" Jeremy Fitzhardinge <jeremy@goop.org> Jes Sorensen <jes@sgi.com> - H. Peter Anvin <hpa@zytor.com> + IA64 <linux-ia64@vger.kernel.org> + David Miller <davem@davemloft.net> peterz@infradead.org + S390 <linux-s390@vger.kernel.org> + Jack Steiner <steiner@sgi.com> + linux-kernel@vger.kernel.org + Eric Dumazet <dada1@cosmosbay.com> + PowerPC <linuxppc-dev@ozlabs.org> + Andi Kleen <andi@firstfloor.org> Thomas Gleixner <tglx@linutronix.de> Yinghai Lu <yhlu.kernel@gmail.com> - IA64 <linux-ia64@vger.kernel.org> - PowerPC <linuxppc-dev@ozlabs.org> - S390 <linux-s390@vger.kernel.org> + H. Peter Anvin <hpa@zytor.com> SPARC <sparclinux@vger.kernel.org> - " linux-kernel@vger.kernel.org\0" + Ingo Molnar <mingo@elte.hu> + " Andrew Morton <akpm@linux-foundation.org>\0" "\00:1\0" "b\0" "On Tuesday 21 October 2008 04:03:37 Mike Travis wrote:\n" @@ -34,13 +34,13 @@ "1) I like the name in this context: it's a beacon of sanity after NR_CPUS and\n" " nr_cpu_ids. But it's not so clearly a win when general code uses it:\n" "\n" - "\tif (cpumask_first(mymask) = nr_cpumask_bits) ...\n" + "\tif (cpumask_first(mymask) == nr_cpumask_bits) ...\n" "\n" " vs:\n" " \n" - "\tif (cpumask_first(mymask) = nr_cpu_ids) ...\n" + "\tif (cpumask_first(mymask) == nr_cpu_ids) ...\n" "\n" - "2) This breaks anyone who tests that the iterators etc. return = nr_cpu_ids.\n" + "2) This breaks anyone who tests that the iterators etc. return == nr_cpu_ids.\n" " One of the other patches tried to change them from NR_CPUS to nr_cpu_ids,\n" " that should now be revisited & reaudited.\n" "\n" @@ -61,4 +61,4 @@ "Rusty.\n" PS. I have part of a patch for this... -9e388c8673d0dbd58afc54b57913e87f7889fde310cad41175df5024c71d3cce +1f504a2425447c2c57942cb9f84efdbae3619a07c39ef9214fbb73166254c9b9
diff --git a/a/content_digest b/N2/content_digest index 6ca302b..4881647 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,24 +4,24 @@ "Subject\0Re: [PATCH 18/35] cpumask: add nr_cpumask_bits\0" "Date\0Tue, 21 Oct 2008 12:26:07 +0000\0" "To\0Mike Travis <travis@sgi.com>\0" - "Cc\0Ingo Molnar <mingo@elte.hu>" - Andi Kleen <andi@firstfloor.org> - Andrew Morton <akpm@linux-foundation.org> - davej@codemonkey.org.uk - David Miller <davem@davemloft.net> - Eric Dumazet <dada1@cosmosbay.com> - Jack Steiner <steiner@sgi.com> + "Cc\0davej@codemonkey.org.uk" Jeremy Fitzhardinge <jeremy@goop.org> Jes Sorensen <jes@sgi.com> - H. Peter Anvin <hpa@zytor.com> + IA64 <linux-ia64@vger.kernel.org> + David Miller <davem@davemloft.net> peterz@infradead.org + S390 <linux-s390@vger.kernel.org> + Jack Steiner <steiner@sgi.com> + linux-kernel@vger.kernel.org + Eric Dumazet <dada1@cosmosbay.com> + PowerPC <linuxppc-dev@ozlabs.org> + Andi Kleen <andi@firstfloor.org> Thomas Gleixner <tglx@linutronix.de> Yinghai Lu <yhlu.kernel@gmail.com> - IA64 <linux-ia64@vger.kernel.org> - PowerPC <linuxppc-dev@ozlabs.org> - S390 <linux-s390@vger.kernel.org> + H. Peter Anvin <hpa@zytor.com> SPARC <sparclinux@vger.kernel.org> - " linux-kernel@vger.kernel.org\0" + Ingo Molnar <mingo@elte.hu> + " Andrew Morton <akpm@linux-foundation.org>\0" "\00:1\0" "b\0" "On Tuesday 21 October 2008 04:03:37 Mike Travis wrote:\n" @@ -61,4 +61,4 @@ "Rusty.\n" PS. I have part of a patch for this... -9e388c8673d0dbd58afc54b57913e87f7889fde310cad41175df5024c71d3cce +d4ba093c1d693474c6b3fd821c295bca90ef951e88578b0078a4ab1b42197042
diff --git a/a/1.txt b/N3/1.txt index 5a01d40..9977a2c 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -8,13 +8,13 @@ On Tuesday 21 October 2008 04:03:37 Mike Travis wrote: 1) I like the name in this context: it's a beacon of sanity after NR_CPUS and nr_cpu_ids. But it's not so clearly a win when general code uses it: - if (cpumask_first(mymask) = nr_cpumask_bits) ... + if (cpumask_first(mymask) == nr_cpumask_bits) ... vs: - if (cpumask_first(mymask) = nr_cpu_ids) ... + if (cpumask_first(mymask) == nr_cpu_ids) ... -2) This breaks anyone who tests that the iterators etc. return = nr_cpu_ids. +2) This breaks anyone who tests that the iterators etc. return == nr_cpu_ids. One of the other patches tried to change them from NR_CPUS to nr_cpu_ids, that should now be revisited & reaudited. diff --git a/a/content_digest b/N3/content_digest index 6ca302b..fa4ec52 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,7 +2,7 @@ "ref\020081020170322.090531000@polaris-admin.engr.sgi.com\0" "From\0Rusty Russell <rusty@rustcorp.com.au>\0" "Subject\0Re: [PATCH 18/35] cpumask: add nr_cpumask_bits\0" - "Date\0Tue, 21 Oct 2008 12:26:07 +0000\0" + "Date\0Tue, 21 Oct 2008 23:26:07 +1100\0" "To\0Mike Travis <travis@sgi.com>\0" "Cc\0Ingo Molnar <mingo@elte.hu>" Andi Kleen <andi@firstfloor.org> @@ -34,13 +34,13 @@ "1) I like the name in this context: it's a beacon of sanity after NR_CPUS and\n" " nr_cpu_ids. But it's not so clearly a win when general code uses it:\n" "\n" - "\tif (cpumask_first(mymask) = nr_cpumask_bits) ...\n" + "\tif (cpumask_first(mymask) == nr_cpumask_bits) ...\n" "\n" " vs:\n" " \n" - "\tif (cpumask_first(mymask) = nr_cpu_ids) ...\n" + "\tif (cpumask_first(mymask) == nr_cpu_ids) ...\n" "\n" - "2) This breaks anyone who tests that the iterators etc. return = nr_cpu_ids.\n" + "2) This breaks anyone who tests that the iterators etc. return == nr_cpu_ids.\n" " One of the other patches tried to change them from NR_CPUS to nr_cpu_ids,\n" " that should now be revisited & reaudited.\n" "\n" @@ -61,4 +61,4 @@ "Rusty.\n" PS. I have part of a patch for this... -9e388c8673d0dbd58afc54b57913e87f7889fde310cad41175df5024c71d3cce +2e328f94d6b4197301e12690885104ae6f7202446562d489fe33d8cd0e262eeb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.