All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: roel kluin <roel.kluin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Make static
Date: Wed, 22 Oct 2008 08:18:45 +0200	[thread overview]
Message-ID: <20081022061845.GB651@elte.hu> (raw)
In-Reply-To: <48FE6A75.5080004@gmail.com>


* roel kluin <roel.kluin@gmail.com> wrote:

> Make static
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
>
> Building an allnoconfig, sparse asked whether these could be static, 
> so I checked, and they are only used in the file where they are 
> declared. This means that they can be static, am I forgetting 
> something? This was build and checkpatch tested.

yeah, it's correct!

>  arch/x86/boot/video-bios.c |    4 ++--
>  arch/x86/boot/video-vesa.c |    4 ++--
>  arch/x86/kernel/xsave.c    |    2 +-

i've applied these bits to tip/x86/urgent,

>  kernel/irq/proc.c          |    2 +-

this bit to tip/irq/urgent,

>  kernel/printk.c            |    2 +-

and this bit to tip/core/urgent.

Thanks Roel,

	Ingo

  reply	other threads:[~2008-10-22  6:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 23:49 [PATCH] Make static roel kluin
2008-10-22  6:18 ` Ingo Molnar [this message]
2008-10-22 10:06 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022061845.GB651@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.